fix(app-router): discard queued server actions on navigation#91044
Open
anujboddu wants to merge 1 commit intovercel:canaryfrom
Open
fix(app-router): discard queued server actions on navigation#91044anujboddu wants to merge 1 commit intovercel:canaryfrom
anujboddu wants to merge 1 commit intovercel:canaryfrom
Conversation
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Discard all queued server actions when a navigation/restore is dispatched so stale queued actions cannot commit state after a route change.
Why?
Issue #90467 reports queued server actions racing with navigation and clobbering
state.canonicalUrl(and related router state). Previously only the currently pending action was discarded; queued actions could still run after navigation and overwrite the new route state.How?
discardedwhen a navigation/restore is dispatched.Fixes #90467
Tests
pnpm lint-eslint packages/next/src/client/components/app-router-instance.ts test/e2e/app-dir/actions/app-action.test.tspnpm testonly-start-webpack ...locally becausepackages/next/dist/build/jest/jestwas missing (build not generated in this environment).