Skip to content

Turbopack: use camel case for import attributes#91317

Open
mischnic wants to merge 2 commits intocanaryfrom
mischnic/rename-turbopack-chunking-type
Open

Turbopack: use camel case for import attributes#91317
mischnic wants to merge 2 commits intocanaryfrom
mischnic/rename-turbopack-chunking-type

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Mar 13, 2026

We already use turbopackLoaderOptions, so let's do the same for turbopack-transition and turbopack-chunking-type

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. type: next labels Mar 13, 2026
@mischnic mischnic changed the title Turbopack: consistently rename to turbopackChunkingType Turbopack: use camel case for import attributes Mar 13, 2026
@mischnic mischnic mentioned this pull request Mar 13, 2026
2 tasks
Copy link
Member Author

mischnic commented Mar 13, 2026

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 13, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▆▆▃▆▃
Cold (Ready in log) 435ms 436ms ▇█▇█▁
Cold (First Request) 1.842s 1.866s ▃▅▄▄▁
Warm (Listen) 455ms 455ms █▁▁▁▁
Warm (Ready in log) 434ms 436ms ▅▆▆▆▁
Warm (First Request) 1.873s 1.885s ▄▅▅▄▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.226s 14.302s ▁▁▂▁▁
Cached Build 14.442s 14.490s ▁▂▁▁▁
node_modules Size 482 MB 482 MB ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.9 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.7 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 255 B 254 B
main-HASH.js gzip 39.2 kB 39.2 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.7 kB -
9544-HASH.js gzip N/A 60.6 kB -
Total 234 kB 235 kB ⚠️ +722 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.51 kB 2.51 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 268 kB 267 kB
Total 393 kB 392 kB ✅ -277 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 615 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.8 kB 43.9 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.4 kB 45.5 kB ⚠️ +63 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.26 MB 4.26 MB
index.pack gzip 109 kB 108 kB
index.pack.old gzip 109 kB 109 kB
Total 4.48 MB 4.48 MB ✅ -4 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 332 kB 332 kB
app-page-exp..prod.js gzip 180 kB 180 kB
app-page-tur...dev.js gzip 332 kB 332 kB
app-page-tur..prod.js gzip 180 kB 180 kB
app-page-tur...dev.js gzip 328 kB 328 kB
app-page-tur..prod.js gzip 178 kB 178 kB
app-page.run...dev.js gzip 329 kB 329 kB
app-page.run..prod.js gzip 178 kB 178 kB
app-route-ex...dev.js gzip 76 kB 76 kB
app-route-ex..prod.js gzip 51.7 kB 51.7 kB
app-route-tu...dev.js gzip 76 kB 76 kB
app-route-tu..prod.js gzip 51.7 kB 51.7 kB
app-route-tu...dev.js gzip 75.6 kB 75.6 kB
app-route-tu..prod.js gzip 51.5 kB 51.5 kB
app-route.ru...dev.js gzip 75.5 kB 75.5 kB
app-route.ru..prod.js gzip 51.4 kB 51.4 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.3 kB 43.3 kB
pages-api-tu..prod.js gzip 33 kB 33 kB
pages-api.ru...dev.js gzip 43.3 kB 43.3 kB
pages-api.ru..prod.js gzip 33 kB 33 kB
pages-turbo....dev.js gzip 52.7 kB 52.7 kB
pages-turbo...prod.js gzip 38.6 kB 38.6 kB
pages.runtim...dev.js gzip 52.7 kB 52.7 kB
pages.runtim..prod.js gzip 38.6 kB 38.6 kB
server.runti..prod.js gzip 62.4 kB 62.4 kB
Total 2.95 MB 2.95 MB ⚠️ +1 B
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/61e86c153197b391b30fd4a559941c8c3b773ca5/next

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2026

Merging this PR will degrade performance by 3.3%

❌ 1 regressed benchmark
✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation packages-bundle.js[full] 1 s 1 s -3.3%

Comparing mischnic/rename-turbopack-chunking-type (61e86c1) with canary (855f0a3)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 13, 2026

Failing test suites

Commit: 61e86c1 | About building and testing Next.js

pnpm test-dev-turbo test/development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts (turbopack) (job)

  • instant-nav-panel > should auto-open panel on page load when cookie is already set (DD)
Expand output

● instant-nav-panel › should auto-open panel on page load when cookie is already set

page.waitForSelector: Timeout 10ms exceeded.
Call log:
  - waiting for locator('[data-instant-nav-client]') to be visible
  -   locator resolved to visible <button class="action-button" data-instant-nav-client="true">…</button>

  525 |
  526 |     return this.startChain(async () => {
> 527 |       const el = await page.waitForSelector(selector, {
      |                             ^
  528 |         timeout,
  529 |         state,
  530 |       })

  at waitForSelector (lib/browsers/playwright.ts:527:29)
  at Playwright._chain (lib/browsers/playwright.ts:657:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:638:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:526:17)
  at Playwright.waitForElementByCss (lib/browsers/playwright.ts:419:17)
  at elementByCssInstant (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:34:19)
  at Object.clickStartClientNav (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:165:11)
  at Proxy._chain (lib/browsers/playwright.ts:657:23)
  at Proxy._chain (lib/browsers/playwright.ts:633:17)
  at Proxy.continueChain (lib/browsers/playwright.ts:477:17)
  at click (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:34:68)
  at Object.clickStartClientNav (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:165:11)

pnpm test-start-turbo test/production/deterministic-build/deployment-id.test.ts (turbopack) (job)

  • deterministic build - changing deployment id > build output API - standard builder > should produce identical build outputs even when changing deployment id (DD)
Expand output

● deterministic build - changing deployment id › build output API - standard builder › should produce identical build outputs even when changing deployment id

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  50 |       }
  51 |
> 52 |       const result = Reflect.apply(target, thisArg, args)
     |                              ^
  53 |       return typeof result === 'function' ? wrapJestTestFn(result) : result
  54 |     },
  55 |     get(target, prop, receiver) {

  at Object.apply (lib/e2e-utils/index.ts:52:30)
  at it (production/deterministic-build/deployment-id.test.ts:261:7)
      at Array.forEach (<anonymous>)
  at production/deterministic-build/deployment-id.test.ts:233:6
  at Object.<anonymous> (production/deterministic-build/deployment-id.test.ts:207:58)

pnpm test-start-turbo test/e2e/app-dir/optimistic-routing/optimistic-routing.test.ts (turbopack) (job)

  • optimistic-routing > optional catch-all: predicts from index to path with segments (DD)
  • optimistic-routing > rewrite detection: detects dynamic rewrite when URL does not match route structure (DD)
Expand output

● optimistic-routing › optional catch-all: predicts from index to path with segments

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  50 |       }
  51 |
> 52 |       const result = Reflect.apply(target, thisArg, args)
     |                              ^
  53 |       return typeof result === 'function' ? wrapJestTestFn(result) : result
  54 |     },
  55 |     get(target, prop, receiver) {

  at Object.apply (lib/e2e-utils/index.ts:52:30)
  at it (e2e/app-dir/optimistic-routing/optimistic-routing.test.ts:145:3)
  at Object.describe (e2e/app-dir/optimistic-routing/optimistic-routing.test.ts:36:1)

● optimistic-routing › rewrite detection: detects dynamic rewrite when URL does not match route structure

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  50 |       }
  51 |
> 52 |       const result = Reflect.apply(target, thisArg, args)
     |                              ^
  53 |       return typeof result === 'function' ? wrapJestTestFn(result) : result
  54 |     },
  55 |     get(target, prop, receiver) {

  at Object.apply (lib/e2e-utils/index.ts:52:30)
  at it (e2e/app-dir/optimistic-routing/optimistic-routing.test.ts:325:3)
  at Object.describe (e2e/app-dir/optimistic-routing/optimistic-routing.test.ts:36:1)

@mischnic mischnic changed the base branch from mischnic/require-turbopackChunkingType to graphite-base/91317 March 13, 2026 15:06
@mischnic mischnic marked this pull request as ready for review March 13, 2026 16:01
@mischnic mischnic force-pushed the graphite-base/91317 branch from 6fbb825 to 7a620f4 Compare March 13, 2026 16:01
@mischnic mischnic force-pushed the mischnic/rename-turbopack-chunking-type branch from 4d40d7f to 16ae770 Compare March 13, 2026 16:01
@mischnic mischnic changed the base branch from graphite-base/91317 to mischnic/require-turbopackChunkingType March 13, 2026 16:02
@mischnic mischnic changed the base branch from mischnic/require-turbopackChunkingType to graphite-base/91317 March 13, 2026 18:19
@mischnic mischnic requested a review from a team March 13, 2026 19:02
@mischnic mischnic force-pushed the graphite-base/91317 branch from 7a620f4 to f1eb8a9 Compare March 14, 2026 10:52
@mischnic mischnic force-pushed the mischnic/rename-turbopack-chunking-type branch from 16ae770 to 5d55a22 Compare March 14, 2026 10:52
@mischnic mischnic changed the base branch from graphite-base/91317 to mischnic/require-turbopackChunkingType March 14, 2026 10:52
@mischnic mischnic changed the base branch from mischnic/require-turbopackChunkingType to graphite-base/91317 March 14, 2026 12:05
@mischnic mischnic force-pushed the graphite-base/91317 branch from f1eb8a9 to 855f0a3 Compare March 14, 2026 12:07
@mischnic mischnic force-pushed the mischnic/rename-turbopack-chunking-type branch from 5d55a22 to 3142bc8 Compare March 14, 2026 12:07
@graphite-app graphite-app bot changed the base branch from graphite-base/91317 to canary March 14, 2026 12:08
@mischnic mischnic force-pushed the mischnic/rename-turbopack-chunking-type branch from 3142bc8 to 61e86c1 Compare March 14, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. type: next

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants