fix(require-hook): guard require.extensions accesses for Node 24.15+ Yarn PnP#92967
Open
sleitor wants to merge 1 commit intovercel:canaryfrom
Open
fix(require-hook): guard require.extensions accesses for Node 24.15+ Yarn PnP#92967sleitor wants to merge 1 commit intovercel:canaryfrom
sleitor wants to merge 1 commit intovercel:canaryfrom
Conversation
…Yarn PnP Node.js v24.15.0 introduced a regression (nodejs/node#61769) where the `require` function exposed to CJS modules loaded via the ESM loader no longer carries the `.extensions` property when the module source comes through a custom loader (e.g. Yarn PnP zip loader). This caused a crash at module evaluation time: TypeError: Cannot read properties of undefined (reading '.js') at require-hook.js:35 The fix guards all `require.extensions` accesses with optional chaining and adds early-return guards in `registerHook`/`deregisterHook` so the build degrades gracefully instead of crashing. No behaviour change on Node versions where `require.extensions` is always defined. Fixes vercel#92935
Contributor
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Guard all
require.extensionsaccesses inpackages/next/src/build/next-config-ts/require-hook.tswith optional chaining / early-return guards.Why?
Node.js v24.15.0 introduced a regression (nodejs/node#61769) where the
requirefunction exposed to CJS modules loaded via the ESM loader no longer carries the.extensionsproperty when the module source comes through a custom loader (e.g. Yarn PnP zip loader).This causes a crash at module evaluation time — before
registerHookis even called — making every Yarn PnP user on Node 24.15+ unable to runnext build:The crash happens regardless of whether the project uses
next.config.tsornext.config.mjsbecausetranspile-config.jsimportsrequire-hook.jseagerly at top level.How?
require.extensions?.['.js']access (prevents crash at evaluation time)if (!require.extensions) returnguards toregisterHookandderegisterHook(defensive early-exit when the hook API is unavailable)require.extensionsis always definedFixes #92935