[ci] Reserve comments for stats and tests#93240
Merged
eps1lon merged 4 commits intoMay 26, 2026
Merged
Conversation
Contributor
Tests PassedCommit: a29f34e |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: a29f34e |
Base automatically changed from
sebbie/04-25-_ci_create_test_summary_comment_if_job_immediately_passes
to
canary
April 25, 2026 14:27
This increases the chances of finding the comments in the same place: at the tippity top of the PR conversation.
eps1lon
force-pushed
the
sebbie/04-25-_ci_reserve_comments_for_stats_and_tests
branch
from
75f81df to
fffc121
Compare
ztanner
reviewed
Apr 25, 2026
| const sha = pr.headSha || workflowRun.head_sha | ||
| const body = [ | ||
| STATS_COMMENT_MARKER, | ||
| '## Stats in progress', |
Member
There was a problem hiding this comment.
Docs-only changes won't trigger the stats workflow, so we'd potentially end up in a state where there's a "Stats in progress" comment that is never fulfilled
Member
Author
There was a problem hiding this comment.
Right. Also did the same for build-and-test in case people cancel
Member
Author
There was a problem hiding this comment.
A docs-only Generate stats actually counts as success: https://github.com/vercel/next.js/actions/runs/24933442991/job/73014965795?pr=93243 -> https://api.github.com/repos/vercel/next.js/actions/runs/24933442991
Member
There was a problem hiding this comment.
It has conclusion: success, but the aggregate/post step is skipped.
So when the reporter handles the completed run, it enters handleStatsWorkflow, sees it was not cancelled, scans the aggregate logs, finds no --stats start-- block, and returns without updating the existing in progress placeholder
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
eps1lon
force-pushed
the
sebbie/04-25-_ci_reserve_comments_for_stats_and_tests
branch
from
34ab3a6 to
772eec5
Compare
eps1lon
force-pushed
the
sebbie/04-25-_ci_reserve_comments_for_stats_and_tests
branch
from
772eec5 to
a29f34e
Compare
unstubbable
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases the chances of finding the comments in the same place: at the tippity top of the PR conversation.