offline navigations: register pass-through worker (3/13)#93625
Draft
feedthejim wants to merge 1 commit intofeedthejim/offline-navigations-manifestfrom
Draft
offline navigations: register pass-through worker (3/13)#93625feedthejim wants to merge 1 commit intofeedthejim/offline-navigations-manifestfrom
feedthejim wants to merge 1 commit intofeedthejim/offline-navigations-manifestfrom
Conversation
This was referenced May 8, 2026
Contributor
Failing test suitesCommit: 7a5e5e9 | About building and testing Next.js
Expand output● hmr-deleted-page › should not show errors for a deleted page |
This was referenced May 8, 2026
19163ff to
ff6adf4
Compare
72b9f6c to
ea2f115
Compare
ff6adf4 to
a7a800c
Compare
ea2f115 to
cc2d61a
Compare
a7a800c to
08e8b61
Compare
cc2d61a to
c997fd8
Compare
08e8b61 to
55a94f7
Compare
This was referenced May 8, 2026
This was referenced May 8, 2026
Contributor
Stats from current PR🔴 1 regression, 1 improvement
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (1 file)Files with changes:
View diffsserver.runtime.prod.jsDiff too large to display 📎 Tarball URLCommit: 7a5e5e9 |
55a94f7 to
7a5e5e9
Compare
c997fd8 to
97a5c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Position
This is PR 3/13 in the compressed offline navigations stack. Chapter: Build artifacts and worker boundary.
Review guide: https://gist.github.com/feedthejim/b3d9fe26a7c05655fd57adcce371b93d
Full Stack
Context
The original offline navigations work was split into 25 staging PRs, which made the review surface too noisy. This compressed stack keeps the same first-usable feature at the tip, but groups the work by reviewer-facing behavior: build artifacts first, exact URL replay next, then route-record replay and invalidation.
The architecture boundary is intentional: the generated service worker keeps the app bootable by serving the fallback document, while the cache-components client router owns IndexedDB, replay eligibility, route reconstruction, visible misses, and invalidation.
Folded source PRs: None.
What This PR Does
What Works After This PR
After this PR, an enabled app can register the generated worker without changing navigation semantics.
What Intentionally Does Not Work Yet
The worker does not cache fallback artifacts or serve the fallback document yet.
Reviewer Focus
Registration timing, scope, generated path, pass-through behavior, and keeping the worker free of router semantics.
Proof in This PR
registers the pass-through service worker when enabled.git diff --check canary..HEADpassed.git diff --stat HEAD f60949e313andgit diff --name-status HEAD f60949e313produced no output, so the compressed tip preserves the previous staging tip.pnpm --filter=next buildpassed.NEXT_TEST_MODE=start pnpm testheadless test/production/app-dir/offline-navigations/offline-navigations.test.tspassed, 12/12.IS_WEBPACK_TEST=1 NEXT_TEST_MODE=start pnpm testheadless test/production/app-dir/offline-navigations/offline-navigations.test.tspassed, 12/12.Deferred Coverage
Install-time caching and navigation fallback handling are deferred.