devlow-bench: percentile-based comparison and run retries#93950
Merged
Conversation
…etection - compare: drop mean and Welch's p; show p50/p90/p99, Δ p50, and a single Mann–Whitney p-value. Hoist the modal n into a banner so only outlier rows carry (n). - runner: buffer each attempt's samples and merge only on success. Retry failed runs until n clean samples are collected (capped at 2× warmup+n). Per-variant and end-of-run failure summaries. - browser: hardNavigation/reload throw when the response is missing or non-2xx, so error pages become failed runs instead of polluted samples.
sokra
approved these changes
May 19, 2026
Contributor
Tests PassedCommit: bea3012 |
wbinnssmith
added a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes to devlow-bench so the comparison output is easier to read and so a couple of flaky page-load runs don't quietly poison the stats.
compare
n = 7 per metricbanner so only the outlier rows carry(n).runner
browser
hardNavigation/reloadnow throw when the navigation response is missing or non-2xx. Previously a200-committed-but-broken page was being recorded as a real sample.The trigger was a run where 2 of 7 cold-build attempts hit an error page, dragging the mean response size from 45 MB to 33 MB while the p50 was unchanged.