Enable experimental.varyParams by default#94010
Merged
Merged
Conversation
Contributor
Tests PassedCommit: 301fdf6 |
acdlite
force-pushed
the
acdlite/enable-vary-params-default
branch
from
0f5ae79 to
bb9eba8
Compare
Inverts the default value of `experimental.varyParams` from `false` to `true`. Part of the Sparkle rollout: each Sparkle feature flag is flipped to its new default one PR at a time so that any regressions land separately and can be bisected. Projects that need the old behavior can still opt out by explicitly setting `experimental.varyParams: false`. Dead branches at the `varyParams` call sites are left in place; they will be cleaned up in a follow-up pass after all four Sparkle flags have been inverted.
acdlite
force-pushed
the
acdlite/enable-vary-params-default
branch
from
bb9eba8 to
301fdf6
Compare
gnoff
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on
experimental.varyParamsby default. First of a short stack flipping the remaining Sparkle flags to their new defaults — landing one flag at a time so any regressions are bisectable.A test in
segment-cache/prefetch-runtimeasserts on the pre-flip root-param cache-keying; pinned tovaryParams: falseuntil the test catches up.