Enable experimental.optimisticRouting by default#94011
Merged
acdlite merged 1 commit intoMay 21, 2026
Merged
Conversation
Contributor
Tests PassedCommit: 5fd4de6 |
0f5ae79 to
bb9eba8
Compare
744e2a4 to
8322815
Compare
Contributor
Stats from current PR🔴 2 regressions
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (1 file)Files with changes:
View diffsserver.runtime.prod.jsDiff too large to display 📎 Tarball URLCommit: 8322815 |
8322815 to
302233b
Compare
Contributor
There was a problem hiding this comment.
Additional Suggestion:
The prefetch-runtime test's next.config.ts is missing optimisticRouting: false, causing the "includes root params, but not dynamic content" test to fail because the new default optimisticRouting: true makes the client optimistically reuse cached prefetch entries instead of fetching new ones for different root param values.
Adds an explicit `optimisticRouting: true` entry to `defaultConfig.experimental` (previously absent, so the flag was implicitly falsy). Part of the Sparkle rollout. Projects that need the old behavior can still opt out by explicitly setting `experimental.optimisticRouting: false`. Dead branches at the `optimisticRouting` call sites are left in place and will be cleaned up after all four Sparkle flags have been inverted.
bb9eba8 to
301fdf6
Compare
302233b to
5fd4de6
Compare
gnoff
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns on
experimental.optimisticRoutingby default. Second of the Sparkle stack.A few tests pin
optimisticRouting: falsebecause their assertions observe the pre-flip navigation timing — search-params, a11y route announcer, and hash scroll. To be updated separately.