Skip to content

turbopack tracing: add chunk_name to get HMR events span#94061

Merged
wbinnssmith merged 1 commit into
canaryfrom
wbinnssmith/add-chunk-name-get-hmr-subscription
May 29, 2026
Merged

turbopack tracing: add chunk_name to get HMR events span#94061
wbinnssmith merged 1 commit into
canaryfrom
wbinnssmith/add-chunk-name-get-hmr-subscription

Conversation

@wbinnssmith
Copy link
Copy Markdown
Member

This adds the chunk's file path to the span as metadata.

@wbinnssmith wbinnssmith requested review from bgw, lukesandberg and sokra and removed request for bgw and lukesandberg May 22, 2026 23:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Tests Passed

Commit: d14ac12

Comment thread crates/next-api/src/project.rs Outdated
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/add-chunk-name-get-hmr-subscription branch from 99aeb0d to 6b4c7e5 Compare May 26, 2026 18:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 26, 2026

Stats skipped

Commit: d14ac12
View workflow run

@wbinnssmith wbinnssmith force-pushed the wbinnssmith/add-chunk-name-get-hmr-subscription branch 5 times, most recently from 019b601 to b9c71c2 Compare May 28, 2026 02:29
Comment thread crates/next-api/src/project.rs Outdated
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/add-chunk-name-get-hmr-subscription branch 2 times, most recently from 92ab975 to 09e120d Compare May 28, 2026 18:49
@wbinnssmith wbinnssmith marked this pull request as ready for review May 28, 2026 20:24
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/add-chunk-name-get-hmr-subscription branch from 09e120d to 225c7ab Compare May 29, 2026 17:17
@wbinnssmith wbinnssmith requested a review from sokra May 29, 2026 18:12
This adds the chunk's file path to the span as metadata.
@wbinnssmith wbinnssmith force-pushed the wbinnssmith/add-chunk-name-get-hmr-subscription branch from 225c7ab to d14ac12 Compare May 29, 2026 18:16
@wbinnssmith wbinnssmith merged commit 88027c2 into canary May 29, 2026
293 of 299 checks passed
@wbinnssmith wbinnssmith deleted the wbinnssmith/add-chunk-name-get-hmr-subscription branch May 29, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants