ServerActionsGraph: pass ModuleGraphLayer as OperationVc#94141
Merged
Conversation
Thread the layer graph through ServerActionsGraph and map_server_actions as an OperationVc, calling connect() at each consumer so the graph is resolved within the consuming task rather than at construction time.
Contributor
Tests PassedCommit: afa9b71 |
Contributor
Stats skippedCommit: afa9b71 |
lukesandberg
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Threads the layer module graph through
ServerActionsGraphandmap_server_actionsas anOperationVcinstead of a resolvedVc, callingconnect()at each consumer.Why?
Fixes the invalidation priority of
map_server_actionsso it is executed after the module graph on incremental builds. Previously, because the graph was resolved at construction time, the dependency ordering causedmap_server_actionsto be re-run before the module graph on incremental rebuilds.How?
By passing the layer graph as an
OperationVcand callingconnect()within each consumer task, the graph is resolved within the consuming task rather than at construction time. This restores the intended invalidation/scheduling order between the module graph andmap_server_actions.