Skip to content

Fix default regex for require.context in Turbopack analyzer#94162

Merged
sampoder merged 1 commit into
canaryfrom
sp/turbopack-require-context-filter
May 27, 2026
Merged

Fix default regex for require.context in Turbopack analyzer#94162
sampoder merged 1 commit into
canaryfrom
sp/turbopack-require-context-filter

Conversation

@sampoder
Copy link
Copy Markdown
Member

@sampoder sampoder commented May 27, 2026

Here is the original bug found by Claude:

static DEFAULT_REGEX: LazyLock<EsRegex> =
      LazyLock::new(|| EsRegex::new(r"^\\./.*$", "").unwrap());

  The raw string is the literal ^\\./.*$. Regex parses \\ as a single backslash,
   so this matches paths starting with \<any>/…. The comment correctly cites
  webpack's default /^\.\/.*$/ ("any file"); the Rust raw string should be
  r"^\./.*$" (single backslash). Today, every default require.context filter
  rejects valid relative paths.

This PR makes the suggested change + adds a unit test that was previously failing but now succeeds.

@sampoder sampoder requested review from bgw and lukesandberg May 27, 2026 18:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 812ms 811ms ✓ █████
Cold (Ready in log) 792ms 792ms ✓ ▆▆▇▅▇
Cold (First Request) 1.248s 1.235s ✓ ▃▂▄▁▄
Warm (Listen) 811ms 811ms ✓ ▆▆▆▆▆
Warm (Ready in log) 792ms 792ms ✓ ▆▅▆▅▆
Warm (First Request) 614ms 614ms ✓ ▅▃▅▂▅
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 811ms 811ms ✓ █████
Cold (Ready in log) 790ms 791ms ✓ ▆█▇▇▇
Cold (First Request) 3.182s 3.210s ✓ ▅▆▃▂▆
Warm (Listen) 811ms 811ms ✓ ▅████
Warm (Ready in log) 789ms 791ms ✓ ▅█▇▇▇
Warm (First Request) 3.213s 3.219s ✓ ▆█▄▃▆

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.782s 4.767s ✓ ▅▅▇▄▅
Cached Build 4.757s 4.764s ✓ ▅▅▆▄▆
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 23.855s 23.877s ✓ ▃█▅▇█
Cached Build 24.094s 24.009s ✓ ▄█▆▇█
node_modules Size 508 MB 508 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
008ypkwxhzol9.js gzip 151 B N/A -
04hm05ar7kldw.js gzip 5.73 kB N/A -
05pjmzkb6_bx2.js gzip 155 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0dj46kukqg96u.js gzip 13.9 kB N/A -
0dvitrl5zg37g.js gzip 8.82 kB N/A -
0gn57unzp9cj7.js gzip 156 B N/A -
0hgh7weswzeyc.js gzip 154 B N/A -
0n_jt34y59ek-.js gzip 156 B N/A -
0q8_3dusot1rk.js gzip 65.6 kB N/A -
0sf7ysou-72zd.js gzip 8.71 kB N/A -
0zt2vt-9glw4j.js gzip 156 B N/A -
13yi-ex_n8ps5.js gzip 156 B N/A -
157abun3hwc_s.js gzip 10.3 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1jpaub6y8xlfr.js gzip 2.3 kB N/A -
1ot0mvscrc_uf.js gzip 233 B N/A -
2_m3xv2uq3sjc.js gzip 1.46 kB N/A -
21fdvwgh64eqz.js gzip 153 B N/A -
22qvit7es5csn.js gzip 159 B N/A -
24y34mwgrkqp4.js gzip 8.78 kB N/A -
2c-fd4y1zozz8.js gzip 8.79 kB N/A -
2d7416h_xd36x.js gzip 8.71 kB N/A -
2jjk__fiybm3z.js gzip 169 B N/A -
2lyuhit6rn8fy.js gzip 9.44 kB N/A -
2q0gr8wfr3jwl.js gzip 8.77 kB N/A -
2t9e75oz6r0zp.js gzip 8.76 kB N/A -
2tu4ozix-297g.js gzip 7.61 kB N/A -
2uku_olcn15b7.js gzip 8.79 kB N/A -
2zsw2-su-qpdk.js gzip 71 kB N/A -
30r8mm-46bdqy.js gzip 220 B 220 B ✓
324onewq6pt5f.js gzip 155 B N/A -
39h0rj3rg3850.js gzip 50.7 kB N/A -
3c1jdxkzlb8oq.js gzip 12.9 kB N/A -
3inab2jybr4k9.js gzip 450 B N/A -
3jkm5tdjvaf_q.js gzip 13.1 kB N/A -
3kw5ih-u7m6yu.js gzip 154 B N/A -
3mt67agm5wp40.js gzip 10.6 kB N/A -
3oabm6bz3ucna.js gzip 159 B N/A -
3saabek4kohwi.js gzip 10 kB N/A -
4189xmby9yu1p.js gzip 13.6 kB N/A -
turbopack-01..n95f.js gzip 4.2 kB N/A -
turbopack-03..08mv.js gzip 4.2 kB N/A -
turbopack-0h..6n_r.js gzip 4.18 kB N/A -
turbopack-0l..d4yd.js gzip 4.2 kB N/A -
turbopack-0t..tddl.js gzip 4.2 kB N/A -
turbopack-15.._7z6.js gzip 4.21 kB N/A -
turbopack-1i..twe9.js gzip 4.2 kB N/A -
turbopack-2h..pd3z.js gzip 4.2 kB N/A -
turbopack-2m..tjab.js gzip 4.2 kB N/A -
turbopack-30..4f3f.js gzip 4.2 kB N/A -
turbopack-38..xmc_.js gzip 4.2 kB N/A -
turbopack-3c..zl6e.js gzip 4.2 kB N/A -
turbopack-3s..8uk3.js gzip 4.2 kB N/A -
turbopack-44..84hz.js gzip 4.2 kB N/A -
0_i7nqgx23st7.js gzip N/A 10 kB -
06puhytyxk31p.js gzip N/A 8.82 kB -
0bu428s3duhqp.js gzip N/A 7.61 kB -
0j_9aszpra-qr.js gzip N/A 13.9 kB -
0j42f9zonj0wd.js gzip N/A 13 kB -
0j55buqga5ouy.js gzip N/A 156 B -
0m34gln_kt4fg.js gzip N/A 5.73 kB -
0ovx4f5ps03mz.js gzip N/A 155 B -
0zc_suxa7omv0.js gzip N/A 155 B -
18to43oll3w6x.js gzip N/A 50.7 kB -
19n2l-u3kwvi0.js gzip N/A 169 B -
1g3q1ww01thnl.js gzip N/A 2.3 kB -
1hraqxuiymq6v.js gzip N/A 8.79 kB -
1l9un1sl77287.js gzip N/A 1.46 kB -
1ordt6-2yc6pp.js gzip N/A 156 B -
1y7i8ky7gxj5l.js gzip N/A 71 kB -
2_zvio6m3evby.js gzip N/A 156 B -
2147zgtf14z-q.js gzip N/A 234 B -
23bz3xsg-5-1s.js gzip N/A 8.71 kB -
27441mytv7pbm.js gzip N/A 9.43 kB -
2cjkwjgm1zcfs.js gzip N/A 8.71 kB -
2m0wbqccqkvo6.js gzip N/A 155 B -
2qtvsrfha8he-.js gzip N/A 152 B -
2scd8zaoyb8md.js gzip N/A 8.79 kB -
2st_qs6p_9us0.js gzip N/A 13.1 kB -
2zo2exm1d8qj1.js gzip N/A 13.6 kB -
3-qwg5kfnixmo.js gzip N/A 162 B -
34bebob8ux4vr.js gzip N/A 157 B -
34h7rhzpjm191.js gzip N/A 160 B -
3g-6cp5tfmp65.js gzip N/A 157 B -
3hn75zuxly9az.js gzip N/A 10.3 kB -
3hqh7m128tvsn.js gzip N/A 8.77 kB -
3hqti_t-zy1x4.js gzip N/A 449 B -
3mnawenie1flm.js gzip N/A 8.76 kB -
3ubsozlu6zs38.js gzip N/A 10.6 kB -
3w0o1l32pu9eg.js gzip N/A 65.6 kB -
43iwfqjnx1cy_.js gzip N/A 8.78 kB -
43xpw4h0vletp.js gzip N/A 156 B -
turbopack-0h..-i0f.js gzip N/A 4.2 kB -
turbopack-0y..2uvo.js gzip N/A 4.21 kB -
turbopack-14..opn5.js gzip N/A 4.2 kB -
turbopack-15..7l0b.js gzip N/A 4.2 kB -
turbopack-15..08rq.js gzip N/A 4.2 kB -
turbopack-15..tzra.js gzip N/A 4.18 kB -
turbopack-1f..qb43.js gzip N/A 4.2 kB -
turbopack-1m..-co8.js gzip N/A 4.2 kB -
turbopack-24..k9f9.js gzip N/A 4.2 kB -
turbopack-2o..2sqn.js gzip N/A 4.2 kB -
turbopack-2y..9e-y.js gzip N/A 4.2 kB -
turbopack-34..wltk.js gzip N/A 4.2 kB -
turbopack-3z..rfcm.js gzip N/A 4.2 kB -
turbopack-43..o0mr.js gzip N/A 4.2 kB -
Total 469 kB 470 kB ⚠️ +69 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 723 B 718 B ✓
Total 723 B 718 B ✅ -5 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 434 B 437 B ✓
Total 434 B 437 B ⚠️ +3 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2258-HASH.js gzip 61.7 kB N/A -
2266-HASH.js gzip 4.69 kB N/A -
3317.HASH.js gzip 169 B N/A -
4866-HASH.js gzip 5.64 kB N/A -
9e302639-HASH.js gzip 62.8 kB N/A -
framework-HASH.js gzip 59.5 kB 59.5 kB ✓
main-app-HASH.js gzip 256 B 254 B ✓
main-HASH.js gzip 39.9 kB 39.9 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
175fd0fd-HASH.js gzip N/A 62.8 kB -
2596-HASH.js gzip N/A 5.63 kB -
34-HASH.js gzip N/A 61.7 kB -
5691.HASH.js gzip N/A 169 B -
9156-HASH.js gzip N/A 4.68 kB -
Total 236 kB 236 kB ✅ -18 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 181 B 182 B ✓
css-HASH.js gzip 334 B 332 B ✓
dynamic-HASH.js gzip 1.79 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 255 B 255 B ✓
head-HASH.js gzip 351 B 348 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 257 B 259 B ✓
link-HASH.js gzip 2.51 kB 2.52 kB ✓
routerDirect..HASH.js gzip 318 B 319 B ✓
script-HASH.js gzip 387 B 386 B ✓
withRouter-HASH.js gzip 316 B 316 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.99 kB ⚠️ +19 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 277 kB 272 kB 🟢 5.3 kB (-2%)
Total 404 kB 398 kB ✅ -5.51 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 614 B ✓
middleware-r..fest.js gzip 155 B 155 B ✓
middleware.js gzip 44.3 kB 44.9 kB 🔴 +575 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 46 kB 46.5 kB ⚠️ +571 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 719 B 717 B ✓
Total 719 B 717 B ✅ -2 B
Build Cache
Canary PR Change
0.pack gzip 4.51 MB 4.51 MB ✓
index.pack gzip 115 kB 114 kB ✓
index.pack.old gzip 114 kB 115 kB ✓
Total 4.74 MB 4.74 MB ✅ -3.25 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 352 kB 352 kB ✓
app-page-exp..prod.js gzip 196 kB 196 kB ✓
app-page-tur...dev.js gzip 351 kB 351 kB ✓
app-page-tur..prod.js gzip 196 kB 196 kB ✓
app-page-tur...dev.js gzip 348 kB 348 kB ✓
app-page-tur..prod.js gzip 194 kB 194 kB ✓
app-page.run...dev.js gzip 348 kB 348 kB ✓
app-page.run..prod.js gzip 194 kB 194 kB ✓
app-route-ex...dev.js gzip 77.6 kB 77.6 kB ✓
app-route-ex..prod.js gzip 52.9 kB 52.9 kB ✓
app-route-tu...dev.js gzip 77.6 kB 77.6 kB ✓
app-route-tu..prod.js gzip 52.9 kB 52.9 kB ✓
app-route-tu...dev.js gzip 77.2 kB 77.2 kB ✓
app-route-tu..prod.js gzip 52.7 kB 52.7 kB ✓
app-route.ru...dev.js gzip 77.2 kB 77.2 kB ✓
app-route.ru..prod.js gzip 52.7 kB 52.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 44.3 kB 44.3 kB ✓
pages-api-tu..prod.js gzip 33.8 kB 33.8 kB ✓
pages-api.ru...dev.js gzip 44.3 kB 44.3 kB ✓
pages-api.ru..prod.js gzip 33.7 kB 33.7 kB ✓
pages-turbo....dev.js gzip 53.7 kB 53.7 kB ✓
pages-turbo...prod.js gzip 39.4 kB 39.4 kB ✓
pages.runtim...dev.js gzip 53.6 kB 53.6 kB ✓
pages.runtim..prod.js gzip 39.4 kB 39.4 kB ✓
server.runti..prod.js gzip 63.1 kB 63.1 kB ✓
use-cache-pr...dev.js gzip 70 kB 70 kB ✓
use-cache-pr...dev.js gzip 70 kB 70 kB ✓
use-cache-pr...dev.js gzip 68.4 kB 68.4 kB ✓
use-cache-pr...dev.js gzip 68.3 kB 68.3 kB ✓
Total 3.38 MB 3.38 MB ✓
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/a67be8e7f20ef9bd4448dd46dc69844f7a9043ac/next

Commit: a67be8e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026 •
edited
Loading

Tests Passed

Commit: a67be8e

@bgw bgw requested a review from a team May 27, 2026 18:16
@sampoder sampoder merged commit 6dbba05 into canary May 27, 2026
300 of 305 checks passed
@sampoder sampoder deleted the sp/turbopack-require-context-filter branch May 27, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgw bgw bgw approved these changes

@lukesandberg lukesandberg Awaiting requested review from lukesandberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sampoder @bgw