Turbopack analyzer: analyze ternaries + promises in string & nullish methods#94187
Merged
Conversation
Contributor
Stats skippedCommit: 4447ecf |
Contributor
Tests PassedCommit: 4447ecf |
sampoder
changed the title
sokra
approved these changes
May 28, 2026
sampoder
force-pushed
the
sp/turbopack_analyzer_tenary
branch
2 times, most recently
from
11690e0 to
87432ad
Compare
sampoder
force-pushed
the
sp/turbopack_analyzer_tenary
branch
from
87432ad to
4447ecf
Compare
sampoder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If in a ternary, we have
x ? y : zand bothyandzare null-ish, then this expression is null-ish. This is also true for if they are both strings, empty strings, or truthy. This PR adds this to the Turbopack analyzer and adds unit tests that cover these cases as well. It is stacked on top of another PR that set up the structure for these unit tests.