Skip to content

Turbopack: cleanup ModuleHotReferenceAssetReference#94206

Merged
mischnic merged 2 commits into
canaryfrom
mischnic/cleanup-hmr-ref
May 29, 2026
Merged

Turbopack: cleanup ModuleHotReferenceAssetReference#94206
mischnic merged 2 commits into
canaryfrom
mischnic/cleanup-hmr-ref

Conversation

@mischnic
Copy link
Copy Markdown
Member

@mischnic mischnic commented May 28, 2026

No need for a separate pub async fn resolve(), just call ModuleReference.resolve_reference directly

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Stats skipped

Commit: 70f8d51
View workflow run

@mischnic mischnic marked this pull request as ready for review May 28, 2026 19:21
@mischnic mischnic requested a review from a team May 28, 2026 19:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

Tests Passed

Commit: 70f8d51

Comment thread turbopack/crates/turbopack-ecmascript/src/references/hot_module.rs Outdated
@mischnic mischnic force-pushed the mischnic/cleanup-hmr-ref branch from aae099d to 70f8d51 Compare May 29, 2026 07:12
@mischnic mischnic enabled auto-merge (squash) May 29, 2026 07:15
@mischnic mischnic merged commit c3e35b5 into canary May 29, 2026
293 of 298 checks passed
@mischnic mischnic deleted the mischnic/cleanup-hmr-ref branch May 29, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants