[turbopack] Separate JsValue into it's own folder in the analyzer#94208
Merged
Conversation
Contributor
Tests PassedCommit: ec9d347 |
Contributor
Stats skippedCommit: ec9d347 |
bgw
requested changes
May 28, 2026
Member
bgw
left a comment
bgw
left a comment
There was a problem hiding this comment.
Other than the minor comments about the imports and the clippy lint, LGTM
bgw
changed the title
JsValue into it's own folder in the analyzerJsValue into it's own folder in the analyzer
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
sampoder
force-pushed
the
sp/turbopack/analyzer-jsvalue-split
branch
from
ce41638 to
3a2f9bb
Compare
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
sampoder
force-pushed
the
sp/turbopack/analyzer-jsvalue-split
branch
from
3a2f9bb to
ec9d347
Compare
bgw
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first in a stack of PRs to break up the analyzer and, eventually, move it to its own crate. There shouldn't be any code changes - everything was just copy and pasted into separate files (let me know if this split makes sense).