Skip to content

[turbopack] Handle negative numbers as constants in the analyzer#94218

Merged
sampoder merged 1 commit into
sp/turbopack/analyzer-well-known-explainfrom
turbopack-analyzer-negative-numbers
May 30, 2026
Merged

[turbopack] Handle negative numbers as constants in the analyzer#94218
sampoder merged 1 commit into
sp/turbopack/analyzer-well-known-explainfrom
turbopack-analyzer-negative-numbers

Conversation

@sampoder
Copy link
Copy Markdown
Member

@sampoder sampoder commented May 29, 2026

Previously, these were unknown / unsupported expressions:

Unknown {
    original_value: None,
    reason: "unsupported expression",
    has_side_effects: true,
},

This prevented us from folding -1 === -1 into true, for example. Most of this PR's changes are updates to the snapshot. It exists in this stack because the code it touches was moved in the stack.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Tests Passed

Commit: 0019d3a

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Stats skipped

Commit: 0019d3a
View workflow run

@sampoder sampoder changed the base branch from canary to sp/turbopack/analyzer-well-known-explain May 29, 2026 06:28
@sampoder sampoder marked this pull request as ready for review May 29, 2026 06:30
@sampoder sampoder requested review from a team, bgw and lukesandberg May 29, 2026 06:31
@sampoder sampoder force-pushed the turbopack-analyzer-negative-numbers branch from 91a6ffa to f1fdb47 Compare May 29, 2026 20:11
@sampoder sampoder force-pushed the sp/turbopack/analyzer-well-known-explain branch 2 times, most recently from e19c4c2 to de9031c Compare May 29, 2026 20:37
@sampoder sampoder force-pushed the turbopack-analyzer-negative-numbers branch from f1fdb47 to 8c145b1 Compare May 29, 2026 20:37
Copy link
Copy Markdown
Contributor

@vercel vercel Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The unrendered-segment error case passes the unfiltered runtimeErrors instead of activeErrors and is missing navigation props (canGoPrevious, canGoNext, onPrevious, onNext), causing incorrect pagination counts and broken prev/next navigation.

Fix on Vercel

@sampoder sampoder force-pushed the sp/turbopack/analyzer-well-known-explain branch from de9031c to c66d3e9 Compare May 29, 2026 22:18
@sampoder sampoder force-pushed the turbopack-analyzer-negative-numbers branch 2 times, most recently from e8c3f45 to bac9ce7 Compare May 29, 2026 22:25
@sampoder sampoder force-pushed the sp/turbopack/analyzer-well-known-explain branch from c66d3e9 to fef788e Compare May 29, 2026 22:31
@sampoder sampoder force-pushed the turbopack-analyzer-negative-numbers branch from bac9ce7 to 1a42441 Compare May 29, 2026 22:31
@sampoder sampoder force-pushed the sp/turbopack/analyzer-well-known-explain branch from fef788e to ff29bae Compare May 29, 2026 23:20
@sampoder sampoder force-pushed the turbopack-analyzer-negative-numbers branch from 1a42441 to 3f17609 Compare May 29, 2026 23:20
@sampoder sampoder force-pushed the sp/turbopack/analyzer-well-known-explain branch 2 times, most recently from fe388f3 to 04ee7e3 Compare May 30, 2026 00:11
@sampoder sampoder force-pushed the turbopack-analyzer-negative-numbers branch from 3f17609 to 0019d3a Compare May 30, 2026 00:12
@sampoder sampoder merged commit 1cd2945 into canary May 30, 2026
274 of 293 checks passed
@sampoder sampoder deleted the turbopack-analyzer-negative-numbers branch May 30, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants