fix(otel): add VCS resource attributes#193
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kakadiadarpan
changed the title
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
dvoytenko
approved these changes
Apr 7, 2026
…was removed from the code in commit 21cfac7. This commit fixes the issue reported at packages/otel/src/types.ts:69 **Bug explanation:** Commit 21cfac7 ("remove ref type attribute") correctly removed the `VCS_REF_TYPE` constant from `semantic-resource-attributes.ts`, its import and usage from `util/attributes.ts`, and its test assertion from `util/attributes.test.ts`. However, two documentation references were left behind: 1. `packages/otel/src/types.ts` line 69: The JSDoc comment for the `Configuration` interface still listed `vcs.ref.type` as a default resource attribute with the description "branch when the Vercel Git ref is available." 2. `packages/otel/README.md` line 50: The attributes documentation still included `vcs.ref.type` in the comma-separated list of default resource attributes. This means the documentation tells users that `vcs.ref.type` will be emitted as a resource attribute, but the code no longer produces it. Users relying on this documented attribute would find it missing from their telemetry data. **Fix explanation:** - Removed the `vcs.ref.type` bullet point from the JSDoc comment in `types.ts`. - Removed `vcs.ref.type` from the comma-separated attribute list in `README.md`. Both documentation sections now accurately reflect the set of default resource attributes actually emitted by the code. Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: kakadiadarpan <hey@kakadiadarpan.com>
Merged
kakadiadarpan
added a commit
that referenced
this pull request
Apr 8, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/otel@2.1.2 ### Patch Changes - [#193](#193) [`937e29a`](937e29a) Thanks [@kakadiadarpan](https://github.com/kakadiadarpan)! - Add standard OpenTelemetry resource attributes for VCS. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Darpan Kakadia <kakadiadarpan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
src/util/attributes.tssrc/semantic-resource-attributes.tsDEPLOYMENT_ENVIRONMENT&VCS_REPOSITORY_REF_VERSIONas deprecated