This repository was archived by the owner on Jan 13, 2024. It is now read-only.
fix issue #1207, Windows: pkg run from disc other than C: #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesec
approved these changes
Jun 6, 2021
lib/common.ts
Outdated
| return `${file[0]}:\\snapshot${file.slice(2)}`; | ||
| // by convention, on windows we use C:\\snapshot | ||
| const pathInSnapshot = `C:\\snapshot${file.slice(2)}`; | ||
| return pathInSnapshot; |
Contributor
There was a problem hiding this comment.
return directly here?
lg2m in principle.
Contributor
Author
There was a problem hiding this comment.
Yes, , I had a console.log at some point while developing, hence I stored the intermediate result in a variable.
Btw, I am struggling to find a way to create a non-regression test for this issue. as I am not sure we can easily create an alternative drive on the CI/CD Windows build image.
Contributor
Author
There was a problem hiding this comment.
I found that subst H: C:\MyFolder will work.
erossignon
force-pushed
the
BugFix/Issue1207
branch
4 times, most recently
from
ff17ffe to
80e45cd
Compare
jesec
reviewed
Jun 7, 2021
erossignon
force-pushed
the
BugFix/Issue1207
branch
from
80e45cd to
ded4d9d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.