Fix NewProtocol classmethod and staticmethod signatures#55
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
msullivan
approved these changes
Jan 26, 2026
| # An annoying thing to know is that for a member classmethod of C, | ||
| # cls *should* be type[C], but if it was not explicitly annotated, it | ||
| # will be C. | ||
| cls_param = Param[typing.Literal["cls"], type[typing.Self], quals] |
Collaborator
There was a problem hiding this comment.
Why do we want to override with typing.Self instead of using what was already there?
Contributor
Author
There was a problem hiding this comment.
type[Self] makes the annotations simpler and makes things easier when combining protocols which may have different receivers. We can use GetDefiner if we really need the actual class.
Collaborator
|
Well, it's possible for code to have explicit annotations on the fields as
well.
Though I'm not sure we handle this correctly now either.
(Maybe we need to have a specific way to distinguish "no annotation is
written". I don't know)
…On Mon, Jan 26, 2026 at 2:07 PM dnwpark ***@***.***> wrote:
Merged #55 <#55> into main.
—
Reply to this email directly, view it on GitHub
<#55 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACTC7MACJLHWI3ZG26XYLL4I2F2JAVCNFSM6AAAAACS6SAEEWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRSGMYDCMRTG44DQMA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_local_defnswe lose track of the origin ofclassmethodandstaticmethodfunctions._callable_type_to_signatureclstotype[Self]