Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
msullivan
reviewed
Jan 29, 2026
Collaborator
msullivan
left a comment
There was a problem hiding this comment.
This seems plausible, but if we are doing this, we probably also need to expose __module__ (and maybe __qualname__?).
And adding one operator for this is probably OK but multiple ones seems to be stretching it.
Would it be too much of a hack to define GetAttr to work on __name__, __module__, and __qualname__ without putting those fields in Members?
If it is, then maybe we could add a GetMetadataAttr that supports stuff like __name__.
Thoughts?
msullivan
approved these changes
Jan 30, 2026
typemap/type_eval/_eval_operators.py
Outdated
Comment on lines
+929
to
+932
| raise TypeError( | ||
| f"Invalid type argument to GetSpecialAttr: " | ||
| f"{attr} must be one of __name__, __module__, or __qualname__" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Probably should return Never
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows getting the
__name__,__module__,__qualname__special attributes.