chore(vercel-sandbox): fix and improve sandbox integration tests#162
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marc-vercel
changed the title
QuiiBz
approved these changes
Apr 27, 2026
LukeSheard
pushed a commit
that referenced
this pull request
May 7, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
LukeSheard
pushed a commit
that referenced
this pull request
May 11, 2026
Test fixes: - Fix the 2 failing tests regarding OIDC by mocking it. - Fix the 2 failing tests regarding killing a command by expecting a 255 instead of 128 + signal code. There was a regression around one month ago where we started returning 255 instead of the 128 + signal code. We can revert back to the previously state if we want to, but for now I am just ensuring the tests pass. - Increase the `afterEach` timeout from 10 seconds (default) to 30 seconds. This is due to the `.stop()` step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot. Other improvements: - Integration tests now create snapshots with an expiration time of 1 day, to ensure they are cleaned up fast. - Integration tests now always delete the sandboxes, to avoid having test sandboxes in the accounts where we run the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test fixes:
afterEachtimeout from 10 seconds (default) to 30 seconds. This is due to the.stop()step being blocking by default. Persistent sandboxes have to stop the sandbox and snapshot.Other improvements: