fix: handle empty stream error in e2e test route#1039
Merged
Conversation
The server rejects empty multipart uploads with "Invalid body". Catch
the error in the route and return { resolved: true } so the test can
verify the upload resolved (no deadlock) regardless of the server
response.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing e2e tests from #1037.
The empty stream multipart e2e test route didn't catch the expected server error ("Invalid body" — the server correctly rejects a 0-part multipart upload). The unhandled error caused a 500, failing the
toBeLessThan(500)assertion.Fix: Catch the error in the route and return
{ resolved: true }. The test now checksresolved === true— the point is thatput()resolved (no deadlock), not that the upload succeeded.🤖 Generated with Claude Code