Skip to content

fix: update background color in TableDownloadDropdown component#133

Merged
haydenbleasel merged 2 commits intovercel:mainfrom
pmontp19:fix/dropdown-bg
Sep 15, 2025
Merged

fix: update background color in TableDownloadDropdown component#133
haydenbleasel merged 2 commits intovercel:mainfrom
pmontp19:fix/dropdown-bg

Conversation

@pmontp19
Copy link
Contributor

@pmontp19 pmontp19 commented Sep 12, 2025

Description

The background color of the Download's button dropdown menu was forced to bg-white. This change applies the theme var bg-background.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Refactoring (no functional changes)

Related Issues

Fixes #132
Closes #
Related to #

Changes Made

  • Change background for the dropdown from bg-white to bg-background

Testing

  • All existing tests pass
  • Added new tests for the changes
  • Manually tested the changes

Test Coverage

Screenshots/Demos

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have created a changeset (pnpm changeset)

Changeset

  • I have created a changeset for these changes

Additional Notes

Would be nice to disable this feature, I found the bug looking how to disable download button.

@vercel
Copy link
Contributor

vercel bot commented Sep 12, 2025

@pmontp19 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@machielvdw
Copy link
Contributor

Was having the same issue. Thanks for fixing 🚀

@thatbeautifuldream
Copy link
Contributor

duplicate pr for #109

@haydenbleasel
Copy link
Member

Merging this PR as it's a more focused fix than #109. Thank you @pmontp19 🙏

@haydenbleasel haydenbleasel merged commit d29281e into vercel:main Sep 15, 2025
2 of 3 checks passed
own-boldsbrain pushed a commit to own-boldsbrain/streamdown that referenced this pull request Sep 22, 2025
…el#133)

* fix: update background color in TableDownloadDropdown component

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect menu styling for code-block download button in dark mode

4 participants