fix(remend): don't complete emphasis/strikethrough markers inside complete inline code spans#426
Merged
haydenbleasel merged 3 commits intovercel:mainfrom Mar 3, 2026
Merged
Conversation
… inline code spans Bold, italic, and strikethrough handlers were using isWithinCodeBlock() which only detects triple-backtick fenced code blocks. Markers inside single-backtick inline code spans (e.g. `**bold`) were incorrectly completed, leaking outside the code span. Fix: - Add isWithinCompleteInlineCode() to code-block-utils.ts that returns true only when a position is inside a *complete* (both delimiters present) inline code span. This preserves the existing streaming behavior where emphasis inside an *incomplete* inline code span (still being streamed) continues to be closed correctly. - Apply the check in handleIncompleteBold, handleIncompleteBoldItalic, handleIncompleteDoubleUnderscoreItalic, handleIncompleteSingleAsterisk- Italic, and handleIncompleteStrikethrough. Fixes vercel#424
Contributor
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Suggestion:
handleIncompleteSingleUnderscoreItalic is missing the isInsideCodeBlock || isWithinCompleteInlineCode guard, causing single underscore markers inside complete inline code spans to be incorrectly completed (e.g., `_italic` becomes `_italic`_).
…SingleUnderscoreItalic
Contributor
|
@sleitor Nice fix! Appreciate it. Can you create a patch changeset file? (run |
Contributor
Author
|
Done — added a patch changeset file in the latest commit. |
Contributor
|
amazing, nice work 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #424
Bold, italic, and strikethrough handlers were using
isWithinCodeBlock()which only detects triple-backtick fenced code blocks. Markers inside single-backtick inline code spans (e.g.**bold *italic `code ~~strike— streaming, closing backtick not yet arrived): the existing streaming behavior is preserved (inline code handler closes the backtick first, then handlers after it append their closers outside)Applied the check in:
handleIncompleteBoldhandleIncompleteBoldItalichandleIncompleteDoubleUnderscoreItalichandleIncompleteSingleAsteriskItalichandleIncompleteStrikethroughTests
Added new test cases in
__tests__/inline-code.test.ts:All 331 tests pass.