fix(streamdown): move mermaid from devDependencies to dependencies#466
Merged
haydenbleasel merged 1 commit intovercel:mainfrom Mar 16, 2026
Merged
fix(streamdown): move mermaid from devDependencies to dependencies#466haydenbleasel merged 1 commit intovercel:mainfrom
haydenbleasel merged 1 commit intovercel:mainfrom
Conversation
The published type declarations (dist/index.d.ts) import MermaidConfig from the mermaid package, making it part of the public API. Having it as a devDependency meant consumers could end up resolving different mermaid versions for streamdown and @streamdown/mermaid, causing type errors due to incompatible MermaidConfig types.
Contributor
|
@smorimoto is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks @smorimoto 🚀 |
|
Due to this change, mermaid is now a forced dependency and this pulls in ~100MB of transitive dependencies. Also, this introduces a ~1MB (ungzipped) build artificat. Can this be implemented in a different way, so mermaid is not a dependency and downstream consumers do not have to suffer from its size, if they opt to not use it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mermaidfromdevDependenciestodependenciesin thestreamdownpackagedist/index.d.ts) importMermaidConfigfrommermaid, making it part of the public APImermaidversions forstreamdownand@streamdown/mermaid, causing type errors due to incompatibleMermaidConfigtypesTest plan
pnpm build:packagessucceedsmermaidoverrides to avoid type mismatches