feat: configurable portal target for Mermaid fullscreen#500
Open
slavco86 wants to merge 2 commits intovercel:mainfrom
Open
feat: configurable portal target for Mermaid fullscreen#500slavco86 wants to merge 2 commits intovercel:mainfrom
slavco86 wants to merge 2 commits intovercel:mainfrom
Conversation
Add mermaid.fullscreenPortalContainer (element or getter) for micro-frontend and prefixed CSS scenarios. Compare mermaid in Streamdown memo for context updates. Document on configuration page; add changeset and tests. Refs vercel#499
Contributor
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Avoid accessing document during render when fullscreen is closed; addresses review feedback on vercel#500.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements vercel/streamdown#499: optional
mermaid.fullscreenPortalContaineronMermaidOptionsso the Mermaid fullscreen overlay can portal into a host element instead ofdocument.body. This helps micro-frontends and apps using scoped or prefixed Tailwind keep the overlay in the same DOM/CSS scope.Changes
MermaidOptions.fullscreenPortalContainer:HTMLElement | null | (() => HTMLElement | null)— unset ornullkeeps the defaultdocument.body.MermaidFullscreenButton: resolves the portal target from context and passes it tocreatePortal.Streamdownmemo: comparemermaidsoStreamdownContextupdates when the portal option (or othermermaidprops) change.configuration.mdx— Mermaid options table.streamdown.Testing
pnpm build:packagespnpm testpnpm checkFixes #499