Rebase 2.0 branch #7974
Closed
Rebase 2.0 branch #7974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description Fixes bug from port where `...` filter would only select immediate dependencies. In Go we used [`graph.Ancestors`](https://github.com/vercel/turbo/blob/v1.10.3/cli/internal/scope/filter/filter.go#L182) which performs a full DFS, not just immediate ancestors. This PR updates so we do the same in Rust. ### Testing Instructions Added unit test that uses `...` filter on a project with transitive dependencies. We already have test cases for the reverse case of [including reverse dependants](https://github.com/vercel/turbo/blob/main/crates/turborepo-lib/src/run/scope/filter.rs#L806) For good measure did a manual check in repo with following dep chain: `docs -> @repo/ui -> foo` ``` [0 olszewski@chriss-mbp] /tmp/dingus $ turbo_dev --skip-infer build --filter=docs... --output-logs=errors-only --no-daemon • Packages in scope: @repo/eslint-config, @repo/typescript-config, @repo/ui, docs, foo • Running build in 5 packages • Remote caching disabled Tasks: 2 successful, 2 total Cached: 2 cached, 2 total Time: 149ms >>> FULL TURBO [0 olszewski@chriss-mbp] /tmp/dingus $ turbo_dev --skip-infer build --filter=...foo --output-logs=errors-only --no-daemon • Packages in scope: @repo/ui, docs, foo, web • Running build in 4 packages • Remote caching disabled Tasks: 3 successful, 3 total Cached: 2 cached, 3 total Time: 9.829s ``` Closes TURBO-2749
Co-authored-by: Turbobot <turbobot@vercel.com>
### Description - sets `COREPACK_ENABLE_DOWNLOAD_PROMPT=0` for the integration tests Newer versions of `corepack` have extra text output when downloading a version, but the environment variable can disable it ### Testing Instructions Observe GH Actions integration tests passing. Closes TURBO-2753 Co-authored-by: Greg Soltis <Greg Soltis>
### Description Added a watcher in `FileWatching` to watch for file changes and map them to packages. Currently you can run this via `turbo daemon watch` but eventually this will be used for watch mode. ### Testing Instructions Run the daemon and use `turbo daemon watch` to see the changed package events as you change files. Closes TURBO-2499
### Description We need to bump the Rust version to use the latest biome crates. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2739 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
### Description Ultra-defensive config loading
### Description Anonymous usage metrics for turbo-ignore. Will help inform future roadmap for the tool.
### Description provide correct conditions for edge ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2915
### Description Fixed the problem of @repo/logger not watching for changes. I think a part of this issue would also be fixed #7871. ### Testing Instructions After running the dev script of the monorepo, making changes in logger package and saving it should result in building the logger package once more.
### Description Closes PACK-1006 I added `fragment` to variants of `Request` ### Testing Instructions I'm not sure about the way to test --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
### Description Removes the `gatsby-plugin-pnpm` dependency because: 1) It doesn't look like it is needed. `turbo build` and `turbo dev` still work. 2) It makes `npm` installation crash. ### Reviewer guide Note that the only substantive changes are `web/package.json` and `web/gatsby-config.ts`. The rest are from npm re-ordering the dependency lists, package manager cleanup, and the lockfile updating. Closes TURBO-2769
…7914) ### Description Some libraries unfortunately use the "deprecated" babel way to import cjs dependencies. `a.js` ```js module.exports = () => {}; ``` `b.js` ```js import * as ns from "./a.cjs"; ns(); ```
### Description That's useless ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2922
### Description This is not fully correct. Removing it. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
### Description While this is still true for some cases it's not the case all the time. Removing for correctness. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
### Description Updates the Turbopack CSS documentation to reflect reality. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
### Description Make sure name is consistent. <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Maia Teegarden <dev@padmaia.rocks>
### Description Update SWC crates. 1. To keep in sync 2. Prepare usage of source map range mappings. getsentry/rust-sourcemap#77 ### Testing Instructions See next.js counterpart. vercel/next.js#63790 Closes PACK-2861
### Description <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2938
### Description <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2939
### Description This should prevent issues when an external module is removed from the require cache leading to 2 version used from the bundle.
…getting started" and starter repo (#7911) ### Description This commit uses the `@repo/` pattern in `math-helpers` example, consistent with the `@repo/` pattern used in the [getting started](https://turbo.build/repo/docs/getting-started/create-new) page and the starter repos. ### Testing Instructions n/a, documentation change Please verify that - I have prefixed the package names correctly with `@repo/` - I did not prefix any folder names by accident!
### Description With watch mode, we want to be able to re-use a `Run` instance between the different executions. We couldn't do this before since `Run::run` would move the struct, but now we have it take a ref. This does require putting the package inputs hashing into `Run::run` instead of in the builder, but I think that's a better fit anyways. This also pulls out analytics from the `Run` struct but that will also be useful for watch mode, since we want to re-use the same analytics handle. ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes TURBO-2779
### Description eslint 9.0.0 has some breaking changes that our current fixture isn't set up to support. This is [preventing us from releasing](https://github.com/vercel/turbo/actions/runs/8693806507/job/23842782558#step:5:256) new versions of `turbo`. Future work is to update the fixture to work with eslint 9 ### Testing Instructions `turbo test --filter=eslint-plugin-turbo` now passes Closes TURBO-2808
turbo-orchestrator
bot
added
area: ci
area: docs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
|
✅ This change can build |
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Closes TURBO-2811