Skip to content

turbopack-240508.1

  • turbopack-240508.1
  • 2652609

  • Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

  • Choose a tag to compare

    View all tags
turbopack-240508.1: feat: Add lint for `grid-template-areas` (#8060)
  • turbopack-240508.1
  • 2652609

  • Choose a tag to compare

    View all tags

  • Partially verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@kdy1 kdy1 tagged this 08 May 08:15 
### Description

> grid-template-areas and grid-area behaves differently in lightningcss
and that leads to some user problems, so we need a check to catches
these errors.
> Since lightning css in css modules is renaming grid area names, you
have to use grid-area and grid-template-areas in the same file together.
Using them in different files would be an error.
> 
> So it would be great to have a check that emits an error when using
grid-area in a CSS file but not declaring the name in
grid-template-areas.

Closes PACK-3022


### Testing Instructions

I added some tests

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Assets 2
Loading