Improve instance verification for deploy#1313
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version, we are printing the building logs when deploying and then exiting once the deployment state changes to
READY. This makes one miss the logs of instances when they are being run so that we would be missing any potential boot failures. Also, we are printing a verification success message per instance in a function that is duplicated across commands.With this PR we are introducing a new
verifyDeploymentScaleasync generator function that yields a tuple[dc: string, instances: number]when the scale requirements of a DC are met for a deployment. Also, it extracts the event stream from the events generator so we can resume logging after we marked the deployment as a build success .Finally, it updates
aliasandscaleto use the same verification function.