Skip to content

Improve instance verification for deploy#1313

Merged
rauchg merged 4 commits into
canaryfrom
refactor-verify-instances
Apr 17, 2018
Merged

Improve instance verification for deploy#1313
rauchg merged 4 commits into
canaryfrom
refactor-verify-instances

Conversation

@javivelasco

@javivelasco javivelasco commented Apr 16, 2018

Copy link
Copy Markdown
Member

In the current version, we are printing the building logs when deploying and then exiting once the deployment state changes to READY. This makes one miss the logs of instances when they are being run so that we would be missing any potential boot failures. Also, we are printing a verification success message per instance in a function that is duplicated across commands.

With this PR we are introducing a new verifyDeploymentScale async generator function that yields a tuple [dc: string, instances: number] when the scale requirements of a DC are met for a deployment. Also, it extracts the event stream from the events generator so we can resume logging after we marked the deployment as a build success .

Finally, it updates alias and scale to use the same verification function.

@javivelasco javivelasco requested review from leo and rauchg April 16, 2018 22:38
@rauchg rauchg merged commit b9364ed into canary Apr 17, 2018
@rauchg rauchg deleted the refactor-verify-instances branch April 17, 2018 00:45
leo pushed a commit that referenced this pull request Apr 17, 2018
* Refactor verify instances for deploy

* Don't rely on return

* Use new verify instances in alias

* Use new verify instances in alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants