Safe deployment polling and other minor fixes#1330
Merged
Merged
Conversation
leo
approved these changes
Apr 26, 2018
leo
pushed a commit
that referenced
this pull request
May 15, 2018
* Initialize polling function from args * Remove rule of having a mandatory dest field in path alias rules * Wait 5 seconds after getting the deployment ready * Ignore errors coming from events stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readyStatefrom in the deployment state polling function and then diff, initialize the state with the value that we already have from the deployment creation. This eliminates the chances of getting stuck because of a state update between the deployment creation and the first polling function call.destin path alias rules json file.