Skip to content

[now-cgi] Remove unused dependency#3878

Merged
kodiakhq[bot] merged 4 commits into
masterfrom
now-cgi-zeit-best
Mar 5, 2020
Merged

[now-cgi] Remove unused dependency#3878
kodiakhq[bot] merged 4 commits into
masterfrom
now-cgi-zeit-best

Conversation

@styfle

@styfle styfle commented Mar 5, 2020

Copy link
Copy Markdown
Member

Removes @zeit/best because it is unused and outdated.

We should considered deprecating @now/cgi since it only gets 4 downloads per week and has no tests.

I also deleted the nested yarn.lock since we only need one at the root for yarn workspaces.

@styfle styfle added dependencies Pull requests that update a dependency file automerge area: tests labels Mar 5, 2020
@styfle styfle requested review from TooTallNate and leo as code owners March 5, 2020 14:31
@codecov

codecov Bot commented Mar 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #3878 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3878   +/-   ##
=======================================
  Coverage   15.97%   15.97%           
=======================================
  Files         227      227           
  Lines        8532     8532           
  Branches     1237     1237           
=======================================
  Hits         1363     1363           
  Misses       6982     6982           
  Partials      187      187           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a0216...e028773. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: tests dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants