[cli] Fix vc dev proxy to upstream frontend dev server#4644
Merged
kodiakhq[bot] merged 11 commits intomasterfrom Jun 15, 2020
Merged
[cli] Fix vc dev proxy to upstream frontend dev server#4644kodiakhq[bot] merged 11 commits intomasterfrom
vc dev proxy to upstream frontend dev server#4644kodiakhq[bot] merged 11 commits intomasterfrom
Conversation
vc dev proxy to upstreamvc dev proxy to upstream frontend dev server
TooTallNate
reviewed
Jun 12, 2020
AndyBitz
approved these changes
Jun 15, 2020
TooTallNate
approved these changes
Jun 15, 2020
This was referenced Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a longstanding issue introduced in #3673 that prevents routing properties from applying to the framework's upstream dev server.
This mimic's the older proxy logic used in build matches here:
vercel/packages/now-cli/src/util/dev/server.ts
Lines 1535 to 1539 in 5035fa5
vercel dev#4510