Skip to content

[cli] Fix vc dev proxy to upstream frontend dev server#4644

Merged
kodiakhq[bot] merged 11 commits intomasterfrom
styfle/ch3112/rewrite-dev
Jun 15, 2020
Merged

[cli] Fix vc dev proxy to upstream frontend dev server#4644
kodiakhq[bot] merged 11 commits intomasterfrom
styfle/ch3112/rewrite-dev

Conversation

@styfle
Copy link
Member

@styfle styfle commented Jun 12, 2020

This PR fixes a longstanding issue introduced in #3673 that prevents routing properties from applying to the framework's upstream dev server.

This mimic's the older proxy logic used in build matches here:

const origUrl = url.parse(req.url || '/', true);
delete origUrl.search;
origUrl.pathname = dest;
Object.assign(origUrl.query, uri_args);
const newUrl = url.format(origUrl);

@styfle styfle marked this pull request as ready for review June 12, 2020 21:57
@styfle styfle changed the title [cli] Fix vc dev proxy to upstream [cli] Fix vc dev proxy to upstream frontend dev server Jun 12, 2020
@vercel vercel bot temporarily deployed to Preview June 12, 2020 22:53 Inactive
@kodiakhq kodiakhq bot merged commit c5a93ec into master Jun 15, 2020
@kodiakhq kodiakhq bot deleted the styfle/ch3112/rewrite-dev branch June 15, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants