-
Notifications
You must be signed in to change notification settings - Fork 43
Add ffmpeg example #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
| return { ...input, filename: safeFilename }; | ||
| } | ||
|
|
||
| async function transcodeAndCompressStep(input: AudioPayload) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use streams instead of buffered data across the wire?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redid moving to sandboxes as vercel-world can't install ffmpeg
README.md
Outdated
|
|
||
| ## Framework Integrations | ||
|
|
||
| - [Express (FFmpeg Processing)](https://github.com/vercel/workflow-examples/tree/main/ffmpeg-processing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe we should move this out of "Framework Integrations" since this feels kinda complex.
imo the point of the framework integrations section was to replicate the "Getting Started" sections of the workflow docs so users can use it as reference
This reverts commit f005e92.
This PR adds a new ffmpeg-processing example that demonstrates how to use Workflow DevKit with an Express app and FFmpeg to compress audio files end‑to‑end.
New example app (ffmpeg-processing):
HTTP API (ffmpeg-processing/src/index.ts):
Workflow + steps (ffmpeg-processing/workflows/audio-convert.ts, ffmpeg-processing/types.ts):
Uses JSON‑safe AudioPayload type shared between route and workflow.