[world-local] Enforce hook token uniqueness and atomicity, matches other worlds#1348
[world-local] Enforce hook token uniqueness and atomicity, matches other worlds#1348VaguelySerious merged 3 commits intomainfrom
Conversation
…her worlds Signed-off-by: Peter Wielander <mittgfu@gmail.com>
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)nextjs-turbopack (1 failed):
🌍 Community Worlds (56 failed)mongodb (3 failed):
redis (2 failed):
turso (51 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
🦋 Changeset detectedLatest commit: dfdf60a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }; | ||
|
|
||
| // Check for duplicate token before creating hook | ||
| const hooksDir = path.join(basedir, 'hooks'); |
There was a problem hiding this comment.
Only minor concern is that if an existing workspace(from before this version) has hook files, a duplicate token can be created once because the constraint file is missing?
There was a problem hiding this comment.
We limit backwards compat in world-local to only ensure old runs can continue running, and can be viewed in o11y, so I think this is fine
karthikscale3
left a comment
There was a problem hiding this comment.
just left one comment, otherwise looks good to me.
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
…ignal * origin/main: fix: separate infrastructure vs user code error handling (#1339) Revert "Fix e2e CLI SIGTERM flake: use SIGKILL to reliably kill hung processes" Fix e2e CLI SIGTERM flake: use SIGKILL to reliably kill hung processes ci: fix git identity for changesets Version Packages commit (#1357) ci: configure git identity for GitHub App bot account (#1356) fix(cli): remove short flag collision on `-e` in health command (#1343) Fix flaky Vercel prod e2e tests by skipping CLI update check (#1350) Fix Windows `ERR_UNSUPPORTED_ESM_URL_SCHEME` in dynamic imports (#1346) Fix flaky hook test by replacing setTimeout with deterministic awaits (#1347) ci: use dedicated GitHub App token instead of shared PAT (#1351) [world-local] Enforce hook token uniqueness and atomicity, matches other worlds (#1348) fix(core): suppress stale WORKFLOW_VERCEL_* env var warning outside serverless runtime (#1345) # Conflicts: # packages/core/src/runtime/step-handler.ts
No description provided.