Fix step-level getWritable() stream timeout on Vercel#1518
Merged
VaguelySerious merged 1 commit intovercel:mainfrom Mar 26, 2026
Merged
Fix step-level getWritable() stream timeout on Vercel#1518VaguelySerious merged 1 commit intovercel:mainfrom
VaguelySerious merged 1 commit intovercel:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: ceolinwill <4393133+ceolinwill@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 4ba509e The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@vercel/workflow This PR is ready for review. |
Contributor
|
@ceolinwill is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
VaguelySerious
approved these changes
Mar 26, 2026
Member
VaguelySerious
left a comment
There was a problem hiding this comment.
Thanks, LGTM, running some more validations before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #770
The step-level
getWritable()used.pipeTo()to pipe serialized data to the server..pipeTo()only resolves when the stream closes, but users typically callwriter.releaseLock()without closing. This caused theopspromise (passed towaitUntil()) to never resolve, keeping the Vercel function alive until runtime timeout.PR #678 fixed this for the stream revivers in
getStepRevivers/getExternalReviversby usingflushablePipe+pollWritableLock, but the step-levelgetWritable()(which is what users call viaimport { getWritable } from 'workflow') was not updated.This PR applies the same
flushablePipe+pollWritableLockpattern togetWritable()so theopspromise resolves as soon as the user releases the writer lock and all pending writes are flushed.How did you test your changes?
Added
packages/core/src/step/writable-stream.test.tswith two tests:All existing tests pass (
pnpm testinpackages/core).PR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PRpnpm changeset --emptyif you are changing documentation or workbench appsgit commit --signoffon your commits)@vercel/workflowin a comment once the PR is ready, and the above checklist is complete