-
Notifications
You must be signed in to change notification settings - Fork 81
feat: workflow/vite plugin
#172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
bba8a50 to
83c2417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Suggestion:
Unused import of workflowRollupPlugin that should be removed since the rollupConfig that used it has been removed.
View Details
📝 Patch Details
diff --git a/workbench/nuxt/nuxt.config.ts b/workbench/nuxt/nuxt.config.ts
index ec2c3bc..023f0a9 100644
--- a/workbench/nuxt/nuxt.config.ts
+++ b/workbench/nuxt/nuxt.config.ts
@@ -1,5 +1,4 @@
import { defineNuxtConfig } from 'nuxt/config';
-import { workflowRollupPlugin } from 'workflow/rollup-plugin';
export default defineNuxtConfig({
compatibilityDate: 'latest',
Analysis
Unused import of workflowRollupPlugin in nuxt.config.ts
What fails: The import import { workflowRollupPlugin } from 'workflow/rollup-plugin'; on line 2 of workbench/nuxt/nuxt.config.ts is not used anywhere in the file and represents dead code.
How to reproduce:
- Search codebase for
workflowRollupPluginusage in workbench/nuxt/nuxt.config.ts: Returns no results - Examine git history: Previous commit (4ca9a3e) shows this import was used in a
rollupConfigproperty that has since been removed - The
rollupConfigwithworkflowRollupPlugin()is no longer present in the current configuration
Result: Import is present but completely unused, causing confusion about code intent
Expected: The unused import should be removed to keep the codebase clean
This PP adds a new
workflow/viteplugin.Usage: (with RFC)
Usage: (without RFC with nitro module)
nitpick: i wish rollup plugin subpath was just called
/rollup...