Skip to content

Conversation

@pi0
Copy link
Collaborator

@pi0 pi0 commented Oct 31, 2025

This PP adds a new workflow/vite plugin.

  • When added alone, adds client transform (similar to rollup)
  • When used in conjuction with nitro (latest nightly) enables module to register workflow handler routes (based on this RFC)
  • Any other vite based framework (like tanstack start) can be added as 3rd plugin

Usage: (with RFC)

import { defineConfig } from 'vite'
import { nitro } from 'nitro/vite'
import { workflow } from 'workflow/vite'

export default defineConfig({
  plugins: [nitro(), workflow(/* config */)]
});

Usage: (without RFC with nitro module)

import { defineConfig } from 'vite'
import { nitro } from 'nitro/vite'

export default defineConfig({
  plugins: [nitro()],
  nitro: { modules: ['workflow/nitro'], workflow: { /* config */ } }
});

nitpick: i wish rollup plugin subpath was just called /rollup...

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2025

⚠️ No Changeset found

Latest commit: 41b5f5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Nov 3, 2025 9:19pm
example-nextjs-workflow-webpack Ready Ready Preview Comment Nov 3, 2025 9:19pm
example-workflow Ready Ready Preview Comment Nov 3, 2025 9:19pm
workbench-nitro-workflow Ready Ready Preview Comment Nov 3, 2025 9:19pm
workbench-sveltekit-workflow Error Error Nov 3, 2025 9:19pm
workbench-vite-workflow Ready Ready Preview Comment Nov 3, 2025 9:19pm
workflow-docs Ready Ready Preview Comment Nov 3, 2025 9:19pm

@pi0 pi0 mentioned this pull request Oct 31, 2025
@socket-security
Copy link

socket-security bot commented Oct 31, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​nitro-nightly@​3.0.1-20251019-172914-d1eea57b ⏵ 3.0.1-20251031-202656-883af4f998 +210082 +196 +1100
Addednpm/​vite@​7.1.12981008299100
Updatednpm/​@​biomejs/​biome@​2.2.5 ⏵ 2.3.394 -610010099 +3100

View full report

@pi0 pi0 changed the title feat: workflow/vite feat: workflow/vite plugin Oct 31, 2025
@pranaygp
Copy link
Collaborator

nitpick: i wish rollup plugin subpath was just called /rollup...
let's change it? it's early enough imo

pi0 and others added 9 commits November 3, 2025 13:07
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

Unused import of workflowRollupPlugin that should be removed since the rollupConfig that used it has been removed.

View Details
📝 Patch Details
diff --git a/workbench/nuxt/nuxt.config.ts b/workbench/nuxt/nuxt.config.ts
index ec2c3bc..023f0a9 100644
--- a/workbench/nuxt/nuxt.config.ts
+++ b/workbench/nuxt/nuxt.config.ts
@@ -1,5 +1,4 @@
 import { defineNuxtConfig } from 'nuxt/config';
-import { workflowRollupPlugin } from 'workflow/rollup-plugin';
 
 export default defineNuxtConfig({
   compatibilityDate: 'latest',

Analysis

Unused import of workflowRollupPlugin in nuxt.config.ts

What fails: The import import { workflowRollupPlugin } from 'workflow/rollup-plugin'; on line 2 of workbench/nuxt/nuxt.config.ts is not used anywhere in the file and represents dead code.

How to reproduce:

  1. Search codebase for workflowRollupPlugin usage in workbench/nuxt/nuxt.config.ts: Returns no results
  2. Examine git history: Previous commit (4ca9a3e) shows this import was used in a rollupConfig property that has since been removed
  3. The rollupConfig with workflowRollupPlugin() is no longer present in the current configuration

Result: Import is present but completely unused, causing confusion about code intent

Expected: The unused import should be removed to keep the codebase clean

Fix on Vercel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants