Fix web/web-shared version drift by marking them as fixed in changesets#1729
Fix web/web-shared version drift by marking them as fixed in changesets#1729TooTallNate merged 1 commit intomainfrom
Conversation
@workflow/web-shared is a devDependency of @workflow/web because it is bundled into web's build output. This means changesets does not bump web's version when only web-shared has changes, causing version drift. Adding both packages to a fixed group ensures they always receive the same version bump. See changesets/changesets#944
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)express (1 failed):
🌍 Community Worlds (74 failed)mongodb (7 failed):
redis (7 failed):
turso (60 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
There was a problem hiding this comment.
Pull request overview
Updates Changesets configuration to prevent version drift between @workflow/web and @workflow/web-shared by forcing them to be bumped together.
Changes:
- Adds
@workflow/weband@workflow/web-sharedas a new"fixed"group in.changeset/config.jsonto keep their versions aligned.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ts (#1729) @workflow/web-shared is a devDependency of @workflow/web because it is bundled into web's build output. This means changesets does not bump web's version when only web-shared has changes, causing version drift. Adding both packages to a fixed group ensures they always receive the same version bump. See changesets/changesets#944
…ts (#1729) @workflow/web-shared is a devDependency of @workflow/web because it is bundled into web's build output. This means changesets does not bump web's version when only web-shared has changes, causing version drift. Adding both packages to a fixed group ensures they always receive the same version bump. See changesets/changesets#944
Summary
@workflow/weband@workflow/web-sharedto a "fixed" group in.changeset/config.jsonso they always receive the same version bump.Problem
@workflow/web-sharedis adevDependencyof@workflow/webbecause it is bundled into web's build output (it does not need to be installed in the end-user'snode_modules). However, this means changesets does not bump@workflow/web's version when only@workflow/web-sharedhas changes, causing version drift between the two packages.This is a known unresolved issue with changesets: changesets/changesets#944
This is exactly what happened in b833e7f ("Version Packages (#1724)") — only
@workflow/web-sharedwas bumped while@workflow/webwas left at its previous version.Fix
By marking both packages as "fixed", changesets will force-bump both packages even if only one of them has changes — the same strategy already used for
workflowand@workflow/core.Supersedes #1727.