Skip to content

[workbench] disable lazyDiscovery in Next.js workbench apps#1804

Open
TooTallNate wants to merge 2 commits into
stablefrom
nr/stable-disable-lazy-discovery-workbench
Open

[workbench] disable lazyDiscovery in Next.js workbench apps#1804
TooTallNate wants to merge 2 commits into
stablefrom
nr/stable-disable-lazy-discovery-workbench

Conversation

@TooTallNate
Copy link
Copy Markdown
Member

Summary

  • Remove lazyDiscovery: true from workbench/nextjs-turbopack/next.config.ts and workbench/nextjs-webpack/next.config.ts
  • Ensures e2e tests on the stable branch exercise the eager discovery path

No published packages change, so no changeset needed.

Removes the lazyDiscovery: true option from the nextjs-turbopack and
nextjs-webpack workbench next.config.ts files so e2e tests exercise the
eager discovery path on the stable branch.
Copilot AI review requested due to automatic review settings April 17, 2026 21:16
@TooTallNate TooTallNate requested a review from a team as a code owner April 17, 2026 21:16
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2026

⚠️ No Changeset found

Latest commit: 7465370

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Apr 17, 2026 9:30pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Apr 17, 2026 9:30pm
example-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-astro-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-express-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-fastify-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-hono-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-nitro-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-nuxt-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workbench-vite-workflow Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workflow-swc-playground Ready Ready Preview, Comment Apr 17, 2026 9:30pm
workflow-web Ready Ready Preview, Comment Apr 17, 2026 9:30pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
workflow-docs Skipped Skipped Apr 17, 2026 9:30pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 17, 2026

🧪 E2E Test Results

No test result files found.


Some E2E test jobs failed:

  • Vercel Prod: success
  • Local Dev: failure
  • Local Prod: failure
  • Local Postgres: failure
  • Windows: success

Check the workflow run for details.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables Next.js “lazy discovery” in the workbench Next.js apps so CI/e2e on stable exercises the eager discovery path in workflow/next by default.

Changes:

  • Remove workflows: { lazyDiscovery: true } from the webpack and turbopack workbench next.config.ts files.
  • Standardize both configs to export default withWorkflow(nextConfig).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
workbench/nextjs-webpack/next.config.ts Stops enabling lazyDiscovery via withWorkflow options so the eager builder path is used.
workbench/nextjs-turbopack/next.config.ts Same: removes lazyDiscovery option to ensure eager discovery is exercised in turbopack workbench app.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants