Skip to content

[world-vercel] Revert stream control framing (stable)#1892

Merged
VaguelySerious merged 2 commits intostablefrom
peter/undo-stream-stable
May 3, 2026
Merged

[world-vercel] Revert stream control framing (stable)#1892
VaguelySerious merged 2 commits intostablefrom
peter/undo-stream-stable

Conversation

@VaguelySerious
Copy link
Copy Markdown
Member

This reverts commit 5ef9ac2 from #1790 (not released to npm yet)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

⚠️ No Changeset found

Latest commit: ddc3c6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment May 3, 2026 2:56am
example-nextjs-workflow-webpack Ready Ready Preview, Comment May 3, 2026 2:56am
example-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-astro-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-express-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-fastify-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-hono-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-nitro-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-nuxt-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-sveltekit-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-vite-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workflow-docs Ready Ready Preview, Comment, Open in v0 May 3, 2026 2:56am
workflow-swc-playground Ready Ready Preview, Comment May 3, 2026 2:56am
workflow-web Ready Ready Preview, Comment May 3, 2026 2:56am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

🧪 E2E Test Results

Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 901 0 67 968
✅ 💻 Local Development 970 0 86 1056
✅ 📦 Local Production 970 0 86 1056
✅ 🐘 Local Postgres 970 0 86 1056
✅ 🪟 Windows 88 0 0 88
❌ 🌍 Community Worlds 139 83 0 222
✅ 📋 Other 246 0 18 264
Total 4284 83 343 4710

❌ Failed Tests

🌍 Community Worlds (83 failed)

mongodb (11 failed):

  • readableStreamWorkflow | wrun_01KQNW4R58B477H68X0NRPWEH3
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KQNW5DT5S79WS0VNR0G89BWV
  • webhookWorkflow | wrun_01KQNW5Q0E70P6NFPV4R2HSPAN
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KQNW92BCJM044Y5322MEFY0R
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KQNWE2C6J5Y0B20BDZKVHQVS
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KQNWMZ23FJBC5MR5Q7ZN8TBP

redis (7 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KQNW5DT5S79WS0VNR0G89BWV
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KQNWE2C6J5Y0B20BDZKVHQVS
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KQNWMZ23FJBC5MR5Q7ZN8TBP

turso (65 failed):

  • addTenWorkflow | wrun_01KQNW44PT0AV22DJ0G0VJ3ETN
  • addTenWorkflow | wrun_01KQNW44PT0AV22DJ0G0VJ3ETN
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KQNW5P8ZJ7DHFMVYNJSXN3AX
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KQNW4DEKMHVYF959T03MHDMT
  • promiseRaceWorkflow | wrun_01KQNW4KF1XGCF2NZDZN6FZYRK
  • promiseAnyWorkflow | wrun_01KQNW4NVH75T7FB335HPA8DQ0
  • importedStepOnlyWorkflow | wrun_01KQNW65ATGAX9SQWMS5K7Z5GT
  • readableStreamWorkflow | wrun_01KQNW4R58B477H68X0NRPWEH3
  • hookWorkflow | wrun_01KQNW51XZVRTHNED32A51MX3Y
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KQNW5DT5S79WS0VNR0G89BWV
  • webhookWorkflow | wrun_01KQNW5Q0E70P6NFPV4R2HSPAN
  • sleepingWorkflow | wrun_01KQNW5YE73DMA7WQ0RZFCXDBG
  • parallelSleepWorkflow | wrun_01KQNW6AYMEBEZ1PJV9VSP6BQD
  • nullByteWorkflow | wrun_01KQNW6FVCPA6M6DXB9H6FEP9R
  • workflowAndStepMetadataWorkflow | wrun_01KQNW6JBW10XNM5SX2XB20F9M
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KQNW92BCJM044Y5322MEFY0R
  • fetchWorkflow | wrun_01KQNW9JDTJDHW40X9VK7YJSDV
  • promiseRaceStressTestWorkflow | wrun_01KQNW9QYGNR6ABVP978CQBACT
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KQNWDCWHVDE7P9Q817THS1E3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KQNWE2C6J5Y0B20BDZKVHQVS
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KQNWERA7T1GZEJXQ4AVPM4QH
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KQNWFDN9GRJAV474XTF6BY38
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KQNWFQFR84SRW2GSYGGZYRRP
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KQNWFXV740TT7K0YP2H7G7X6
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KQNWG0854KNQKPQPN01G6RSW
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KQNWGH21H040KRY9G3PMEH4Z
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KQNWGQ91MSTH0TMNNCDQAAGT
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KQNWGZ5Y3F3VBSKDT3TVYY8Y
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KQNWH6D7SZXAQF8E9R6N9XSN
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KQNWHDMJFAZDVJTNB0EWBTK2
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KQNWHMZCDTV7EKT4TT64N7HG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KQNWHWBK0VGE0THDR5SXNFMP
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KQNWJ8M3S33FTAHC6WP9T92D
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KQNWJH01M8EE17V3CCMJJ76Q
  • cancelRun - cancelling a running workflow | wrun_01KQNWJSNGM2BYJCRN93VYG10T
  • cancelRun via CLI - cancelling a running workflow | wrun_01KQNWK3CC65F66QW95V35W5TS
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KQNWKG39XC2ZQ2BSRQ4E0VMH
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KQNWM6J76RFAQ5Y4WQ3H0NS0
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KQNWMHJE48AXAJ7KYB3RTXY2
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KQNWMTPG2S7VH3K237C2TW87
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KQNWMX0DQWEPJ13C6FC1GZSE
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KQNWMZ23FJBC5MR5Q7ZN8TBP

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 81 0 7
✅ example 81 0 7
✅ express 81 0 7
✅ fastify 81 0 7
✅ hono 81 0 7
✅ nextjs-turbopack 86 0 2
✅ nextjs-webpack 86 0 2
✅ nitro 81 0 7
✅ nuxt 81 0 7
✅ sveltekit 81 0 7
✅ vite 81 0 7
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 88 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 5 0 0
❌ mongodb 58 11 0
✅ redis-dev 5 0 0
❌ redis 62 7 0
✅ turso-dev 5 0 0
❌ turso 4 65 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 82 0 6
✅ e2e-local-postgres-nest-stable 82 0 6
✅ e2e-local-prod-nest-stable 82 0 6

📋 View full workflow run

@VaguelySerious VaguelySerious changed the title [world-vercel] Revert stream control framing [world-vercel] Revert stream control framing (stable) May 2, 2026
@VaguelySerious VaguelySerious marked this pull request as ready for review May 2, 2026 01:04
@VaguelySerious VaguelySerious requested a review from TooTallNate May 2, 2026 04:35
Copy link
Copy Markdown
Member

@TooTallNate TooTallNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert of the unreleased #1790 control-frame work to make way for the cleaner frame-counting approach in #1847. The diff matches expectations: control-frame constants and helpers (STREAM_CONTROL_FRAME_SIZE, parseStreamControlFrame), the reconnect loop in readFromStream, and all related tests are removed; nothing else is touched. Since #1790 hadn't shipped to npm there's no compatibility surface to worry about.

@VaguelySerious VaguelySerious enabled auto-merge (squash) May 2, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants