Skip to content

[stable] Backport inline sourcemap remap hardening#2156

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable
May 29, 2026
Merged

[stable] Backport inline sourcemap remap hardening#2156
VaguelySerious merged 1 commit into
stablefrom
peter/backport-inline-sourcemap-stable

Conversation

@VaguelySerious
Copy link
Copy Markdown
Member

@VaguelySerious VaguelySerious commented May 29, 2026

Backports 2ff8317 onto stable.

This keeps workflow error stack remapping from running a regex over large inline sourcemap bundles and adds regression coverage.

Validation:

  • pnpm exec vitest run packages/core/src/source-map.test.ts
  • pnpm --filter @workflow/core... build
  • pnpm --filter @workflow/core typecheck
  • pnpm --filter @workflow/core test
  • pnpm exec biome check packages/core/src/source-map.ts packages/core/src/source-map.test.ts .changeset/large-inline-sourcemap-remap.md

Note: pnpm lint currently fails on pre-existing stable-branch diagnostics outside this change (Biome schema drift, node: import rules, generated SvelteKit formatting, and unrelated complexity/unused-variable diagnostics).

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 29, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment May 29, 2026 11:14am
example-nextjs-workflow-webpack Ready Ready Preview, Comment May 29, 2026 11:14am
example-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-astro-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-express-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-fastify-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-hono-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-nitro-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-nuxt-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-sveltekit-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-tanstack-start-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workbench-vite-workflow Ready Ready Preview, Comment May 29, 2026 11:14am
workflow-docs Ready Ready Preview, Comment, Open in v0 May 29, 2026 11:14am
workflow-swc-playground Ready Ready Preview, Comment May 29, 2026 11:14am
workflow-tarballs Ready Ready Preview, Comment May 29, 2026 11:14am
workflow-web Ready Ready Preview, Comment May 29, 2026 11:14am

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 29, 2026

🦋 Changeset detected

Latest commit: ca7606b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/vitest Patch
@workflow/web-shared Patch
@workflow/web Patch
workflow Patch
@workflow/world-testing Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026 •
edited
Loading

🧪 E2E Test Results

❌ Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 901 0 67 968
✅ 💻 Local Development 970 0 86 1056
✅ 📦 Local Production 970 0 86 1056
✅ 🐘 Local Postgres 970 0 86 1056
✅ 🪟 Windows 88 0 0 88
❌ 🌍 Community Worlds 15 69 0 84
✅ 📋 Other 492 0 36 528
Total 4406 69 361 4836

❌ Failed Tests

🌍 Community Worlds (69 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (66 failed):

  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • addTenWorkflow | wrun_01KSSPXR77TG2VCY8RQCRRQGMG
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KSSPZXD7ZJK9AA2VTTQ2FMJZ
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KSSPY0ZM7N7Q0DP0YFF4KX5E
  • promiseRaceWorkflow | wrun_01KSSPY65M8HA9GG8T4MBZ0STR
  • promiseAnyWorkflow | wrun_01KSSPY8EDHH1GXYZFY4KWRCDE
  • importedStepOnlyWorkflow | wrun_01KSSQ08A2AYKDA9RD0TEHJ9G1
  • readableStreamWorkflow | wrun_01KSSPYD9VNSYQKP6C16JJBG77
  • hookWorkflow | wrun_01KSSPYTCTPRCX1JZ29170ANY8
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KSSPZ551Z0S7CSED1YNV5G9F
  • webhookWorkflow | wrun_01KSSPZA18X24WDCH4DFPGZV2F
  • sleepingWorkflow | wrun_01KSSPZFGV5CDZ31TG267WWSCN
  • parallelSleepWorkflow | wrun_01KSSPZYRREVYF56Y7XC3WJV4Z
  • nullByteWorkflow | wrun_01KSSQ0847NNNN6RB9AVG9PYPH
  • workflowAndStepMetadataWorkflow | wrun_01KSSQ0AXYWB59R06A8V1RNRYH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KSSQ2PFCSJM290EBFF95Z7AS
  • fetchWorkflow | wrun_01KSSQ347QMW1V8A12XC72YJKN
  • promiseRaceStressTestWorkflow | wrun_01KSSQ37N07M01VF648W3ACK5Y
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KSSQ6SJ0W2PQ0QWRTYRG4CH3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KSSQ75ANRH2NXMVF7X52WZRQ
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KSSQ7NGSMNQB74Z6WBCA8ARJ
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KSSQ8705MCAJ0G912AYVVC7F
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KSSQ8G7T96PFV0QRZKG56WBD
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KSSQ8P2WDM00QPP192QJPW62
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KSSQ8R98D0EMZ48H0GA2HBMJ
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KSSQ98JFXQ6N2E9FY4W13EP0
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KSSQ9MBK1E6YTTWDSHX1S0SM
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KSSQ9V6HED92FPHJJRTA9H4V
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KSSQA24D7YPNKNCMVFKD218K
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KSSQA96RDABEXVPM07DTT8QM
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KSSQAG0ZXM8EP39588G3R2TG
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KSSQAPZ6401DG0VXTH3J7266
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KSSQB3R6N4JSA9V4MDSA9J6E
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KSSQBCXZEQGKBGG86G4VF1A8
  • cancelRun - cancelling a running workflow | wrun_01KSSQBKV0BZ3J063AY77FHR8X
  • cancelRun via CLI - cancelling a running workflow | wrun_01KSSQBXH343DWH2BSDAYE48DJ
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KSSQCA1WY69CBC0PHPA9WB3D
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KSSQCT3HHS8Q20QGMSGBA6M3
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KSSQD5WSY768PKWEV42PC6K3
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KSSQDE4J6TCSYM03EZNB9KKE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KSSQDGAEVVV28FVHB26B6S7J
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KSSQDJEK6AP93TJJGS7H1EDF

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 81 0 7
✅ example 81 0 7
✅ express 81 0 7
✅ fastify 81 0 7
✅ hono 81 0 7
✅ nextjs-turbopack 86 0 2
✅ nextjs-webpack 86 0 2
✅ nitro 81 0 7
✅ nuxt 81 0 7
✅ sveltekit 81 0 7
✅ vite 81 0 7
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 88 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
❌ mongodb-dev 4 1 0
❌ redis-dev 4 1 0
❌ turso-dev 4 1 0
❌ turso 3 66 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 82 0 6
✅ e2e-local-dev-tanstack-start-stable 82 0 6
✅ e2e-local-postgres-nest-stable 82 0 6
✅ e2e-local-postgres-tanstack-start-stable 82 0 6
✅ e2e-local-prod-nest-stable 82 0 6
✅ e2e-local-prod-tanstack-start-stable 82 0 6

📋 View full workflow run

@VaguelySerious VaguelySerious marked this pull request as ready for review May 29, 2026 11:11
@VaguelySerious VaguelySerious requested a review from a team as a code owner May 29, 2026 11:11
@VaguelySerious VaguelySerious enabled auto-merge (squash) May 29, 2026 16:10
@VaguelySerious VaguelySerious disabled auto-merge May 29, 2026 17:56
@VaguelySerious VaguelySerious merged commit ebfeede into stable May 29, 2026
155 of 162 checks passed
@VaguelySerious VaguelySerious deleted the peter/backport-inline-sourcemap-stable branch May 29, 2026 17:57
@github-actions github-actions Bot mentioned this pull request May 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TooTallNate TooTallNate TooTallNate approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious @TooTallNate