Fix circular dependency in workflow package runtime#916
Merged
VaguelySerious merged 5 commits intomainfrom Feb 2, 2026
Merged
Conversation
…changeset Signed-off-by: Peter Wielander <mittgfu@gmail.com>
🦋 Changeset detectedLatest commit: 2b35b24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Move the Run class to its own file (runtime/run.ts) to break the circular dependency that was causing issues with Bun's module resolution. The cycle was: - runtime.ts re-exports start from runtime/start.ts - runtime/start.ts imports Run from runtime.ts Now both files import Run from runtime/run.ts, eliminating the cycle. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Peter Wielander <mittgfu@gmail.com>
VaguelySerious
force-pushed
the
peter/fix-runtime-circular-dependency
branch
from
2057f27 to
c18e405
Compare
Contributor
🧪 E2E Test Results⏳ Tests are running... This comment will be updated with the results when the tests complete. Started at: 2026-02-02T19:18:26Z |
Contributor
📊 Benchmark Results⏳ Benchmarks are running... This comment will be updated with the results when the benchmarks complete. Started at: 2026-02-02T19:20:06Z |
VaguelySerious
commented
Feb 2, 2026
| "@workflow/docs-typecheck": "0.0.0", | ||
| "@workflow/serde": "4.0.0", | ||
| "@workflow/nest": "0.0.0-development", | ||
| "@workflow/nest": "4.0.0", |
Member
Author
There was a problem hiding this comment.
This fixes nest version starting at 0.0.0. No actual change otherwise.
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
TooTallNate
approved these changes
Feb 2, 2026
karthikscale3
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just moves the
Runclass into its own file