-
Notifications
You must be signed in to change notification settings - Fork 10
uv and pyproject.toml #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3071fca to
5fdd85b
Compare
| authentication_service.authenticate() | ||
|
|
||
| x = responses.calls[0].request | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not used (pointed out by Ruff linter).
| status=202, | ||
| match=[ | ||
| responses.json_params_matcher({ | ||
| matchers.json_params_matcher({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes a deprecation warning.
e51c518 to
06face7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module removed to prevent confusion with commonly expected: from datacrunch import __version__; print(__version__).
|
|
||
| [tool.ruff] | ||
| # TODO(shamrin) fix these errors and stop ignoring them | ||
| lint.ignore = ["E721", "E711", "E712", "F401"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See next PR #50
jaakkovarjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
Migrate to
uvandpyproject.toml.To upgrade local development environment, install uv and run:
Virtual environment changes:
uv run. But, if you must, activating is still possible.Python: Select Intepreter->./.venv/bin/pythonSee changelog for more details.
TODO
setup.py/setuptoolstopyproject.toml/uv/uv_builduvin all workflowsLater: