Skip to content

Feature/add spot instance support#6

Merged
tamirse merged 3 commits intomasterfrom
feature/add_spot_instance_support
Sep 16, 2022
Merged

Feature/add spot instance support#6
tamirse merged 3 commits intomasterfrom
feature/add_spot_instance_support

Conversation

@tamirse
Copy link
Copy Markdown
Collaborator

@tamirse tamirse commented Sep 16, 2022

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 16, 2022

Codecov Report

Base: 99.29% // Head: 99.49% // Increases project coverage by +0.19% 🎉

Coverage data is based on head (17d524a) compared to base (b0959fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   99.29%   99.49%   +0.19%     
==========================================
  Files          15       16       +1     
  Lines         571      589      +18     
==========================================
+ Hits          567      586      +19     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
datacrunch/helpers.py 100.00% <100.00%> (ø)
datacrunch/images/images.py 100.00% <100.00%> (ø)
datacrunch/instances/instances.py 99.07% <100.00%> (+1.05%) ⬆️
datacrunch/volumes/volumes.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tamirse tamirse requested a review from gradjitta September 16, 2022 09:18
@gradjitta
Copy link
Copy Markdown
Collaborator

I checked the code and usage of stringify_class_object_properties Looks good to me

Copy link
Copy Markdown
Collaborator

@gradjitta gradjitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@tamirse tamirse merged commit 090a926 into master Sep 16, 2022
@tamirse tamirse deleted the feature/add_spot_instance_support branch October 18, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<datacrunch.instances.instances.Instance object at 0x1105e4910> when .get is called

2 participants