Skip to content

Conversation

@huksley
Copy link
Collaborator

@huksley huksley commented Dec 8, 2025

@huksley huksley requested a review from shamrin December 8, 2025 11:15
=======

.. autoclass:: verda.balance.balance.BalanceService
.. autoclass:: verda.balance._balance.BalanceService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those should be in form of verda.balance.BalanceService instead.

=======

.. autoclass:: verda.balance.balance.BalanceService
.. autoclass:: verda.balance._balance.BalanceService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.balance._balance.BalanceService
.. autoclass:: verda.balance..BalanceService

:members:

.. autoclass:: verda.balance.balance.Balance
.. autoclass:: verda.balance._balance.Balance
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.balance._balance.Balance
.. autoclass:: verda.balance..Balance

==========

.. autoclass:: verda.containers.containers.ContainersService
.. autoclass:: verda.containers._containers.ContainersService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.containers._containers.ContainersService
.. autoclass:: verda.containers..ContainersService

:members:

.. autoclass:: verda.containers.containers.Container
.. autoclass:: verda.containers._containers.Container
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.containers._containers.Container
.. autoclass:: verda.containers..Container

======

.. autoclass:: verda.images.images.ImagesService
.. autoclass:: verda.images._images.ImagesService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.images._images.ImagesService
.. autoclass:: verda.images..ImagesService

:members:

.. autoclass:: verda.startup_scripts.startup_scripts.StartupScript
.. autoclass:: verda.startup_scripts._startup_scripts.StartupScript
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.startup_scripts._startup_scripts.StartupScript
.. autoclass:: verda.startup_scripts.StartupScript

============

.. autoclass:: verda.volume_types.volume_types.VolumeTypesService
.. autoclass:: verda.volume_types._volume_types.VolumeTypesService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.volume_types._volume_types.VolumeTypesService
.. autoclass:: verda.volume_types.VolumeTypesService

:members:

.. autoclass:: verda.volume_types.volume_types.VolumeType
.. autoclass:: verda.volume_types._volume_types.VolumeType
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.volume_types._volume_types.VolumeType
.. autoclass:: verda.volume_types.VolumeType

=======

.. autoclass:: verda.volumes.volumes.VolumesService
.. autoclass:: verda.volumes._volumes.VolumesService
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.volumes._volumes.VolumesService
.. autoclass:: verda.volumes.VolumesService

:members:

.. autoclass:: verda.volumes.volumes.Volume
.. autoclass:: verda.volumes._volumes.Volume
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. autoclass:: verda.volumes._volumes.Volume
.. autoclass:: verda.volumes.Volume

@freetonik
Copy link
Collaborator

I made some other changes in a parallel MR, and it also applies the fixes I propose here. #66

@shamrin
Copy link
Collaborator

shamrin commented Dec 9, 2025

@freetonik @huksley It would be nice to avoid using underscore _module if we can.

@huksley
Copy link
Collaborator Author

huksley commented Dec 10, 2025

superseded by #66
please also review #64

@huksley huksley closed this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants