Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

refactor: adds unit tests for api service#235

Merged
juanpicado merged 4 commits intomasterfrom
adds-test-for-api-client
Nov 1, 2019
Merged

refactor: adds unit tests for api service#235
juanpicado merged 4 commits intomasterfrom
adds-test-for-api-client

Conversation

@ayusharma
Copy link
Copy Markdown
Member

Type: unit test

The following has been addressed in the PR:

  • There is a related issue? No
  • Unit or Functional tests are included in the PR? Yes

Description:
adds unit tests for api service

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2019

Codecov Report

Merging #235 into master will increase coverage by 1.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   88.85%   90.27%   +1.42%     
==========================================
  Files         139      139              
  Lines         915      915              
  Branches      142      160      +18     
==========================================
+ Hits          813      826      +13     
+ Misses         91       75      -16     
- Partials       11       14       +3
Impacted Files Coverage Δ
src/utils/styles/media.ts 81.81% <0%> (ø) ⬆️
src/components/DetailSidebar/DetailSidebar.tsx 85% <0%> (ø) ⬆️
src/utils/api.ts 92% <0%> (+52%) ⬆️

@verdacciobot
Copy link
Copy Markdown

Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes:

npm install @verdaccio/ui-theme@v0.3.5-b6a79b9-pr235.0 --registry https://registry.verdaccio.org

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great @ayusharma 🚀

@juanpicado juanpicado merged commit 803da1c into master Nov 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the adds-test-for-api-client branch November 1, 2019 06:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants