This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: engine warning on console for ui#403
Merged
juanpicado merged 5 commits intomasterfrom Dec 30, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=========================================
Coverage ? 87.81%
=========================================
Files ? 137
Lines ? 952
Branches ? 211
=========================================
Hits ? 836
Misses ? 102
Partials ? 14 |
DanielRuf
previously approved these changes
Dec 30, 2019
Member
Author
|
Yes, it does, but I think nobody is developing on Node 8` anyway. The change webpack-contrib/url-loader#198 does not affect the library behavior. This is just a dependency and we ship a webpack bundle. I updated the README. |
Contributor
You are right. I saw the other comment about the |
DanielRuf
previously approved these changes
Dec 30, 2019
Co-Authored-By: Daniel Ruf <827205+DanielRuf@users.noreply.github.com>
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
DanielRuf
approved these changes
Dec 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
We still support
v8and this is a dependency of verdaccio.Resolves https://github.com/verdaccio/ui/issues/402