This repository was archived by the owner on Jan 16, 2022. It is now read-only.
feat(de-translations): added de-DE translations to the UI#441
Merged
priscilawebdev merged 13 commits intomasterfrom Mar 12, 2020
Merged
feat(de-translations): added de-DE translations to the UI#441priscilawebdev merged 13 commits intomasterfrom
priscilawebdev merged 13 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 88.08% 87.55% -0.54%
==========================================
Files 140 140
Lines 982 988 +6
Branches 204 204
==========================================
Hits 865 865
- Misses 106 112 +6
Partials 11 11
|
Member
|
LGTM, but I'd rather trust on @DanielRuf 👍 |
jan-auer
reviewed
Mar 11, 2020
jan-auer
left a comment
jan-auer
left a comment
There was a problem hiding this comment.
Sounds really good, here are a few suggestions.
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Co-Authored-By: Jan Michael Auer <account@jauer.org>
Contributor
Author
|
@jan-auer Thank you very much for all the suggestions 😉 I've applied all of them. |
…ui into feat/added-de-at-translations
priscilawebdev
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
juanpicado
approved these changes
Mar 12, 2020
juanpicado
reviewed
Mar 12, 2020
juanpicado
reviewed
Mar 12, 2020
| dayjs.locale('pt-br'); | ||
| } | ||
| break; | ||
| case 'de': |
Contributor
Author
There was a problem hiding this comment.
nope... de is the default one 😉 Please see: https://github.com/iamkun/dayjs/tree/dev/src/locale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feat
Description:
follow up of #432