add a new language - Ukrainian && fix bug with dayjs locale#472
add a new language - Ukrainian && fix bug with dayjs locale#472priscilawebdev merged 10 commits intoverdaccio:masterfrom
Conversation
|
@mikollaay thank you for your contribution 🙂Please could you describe the issue you fixed? |
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
A small change in Spanish translation 👍
|
Bundlesize is failing, please ignore it, we should increase size since we are adding new translations, not a big problem :) |
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 82.72% 82.80% +0.07%
==========================================
Files 142 142
Lines 1077 1082 +5
Branches 210 209 -1
==========================================
+ Hits 891 896 +5
Misses 154 154
Partials 32 32
|
|
Date is always in English allocated fix code last commit 53f8d56 |
src/App/load-dayjs-locale.ts
Outdated
| } | ||
|
|
||
| switch (locale.toLowerCase()) { | ||
| case 'en-us': |
There was a problem hiding this comment.
In this case I believe that en-us should be the default
src/App/load-dayjs-locale.ts
Outdated
| return; | ||
| } | ||
|
|
||
| switch (locale.toLowerCase()) { |
There was a problem hiding this comment.
locale?.toLowerCase()
| useEffect(() => { | ||
| changeLanguage(); | ||
| }, [language, changeLanguage]); | ||
| loadDayJSLocale(); |
There was a problem hiding this comment.
now I know the bug you have fixed... good catch! thanks :)
|
@mikollaay if you don't mind I will update with a small fix, so then the tests will pass and we can have it merged ;-) |
|
SonarCloud Quality Gate failed.
|
|
👍 |
3 participants
Type:
The following has been addressed in the PR:
Description: