Remove capitalisation from greeting label#595
Remove capitalisation from greeting label#595priscilawebdev merged 3 commits intoverdaccio:masterfrom
Conversation
|
I actually like this feature. Can we have the option to choose whether we want capitalisation or not? Could you code that in as well @imjacobclark ? |
I think first would be to resolve for the simplest case and then potentially raise a ticket to customise in future. |
priscilawebdev
left a comment
priscilawebdev
left a comment
There was a problem hiding this comment.
I agree with you @imjacobclark Thanks for the PR 😉
Thanks @priscilawebdev! What's required to get this change merged? Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 79.62% 79.55% -0.08%
==========================================
Files 166 166
Lines 1291 1291
Branches 234 234
==========================================
- Hits 1028 1027 -1
Misses 224 224
- Partials 39 40 +1
|
|
Kudos, SonarCloud Quality Gate passed!
|
3 participants
Type:
The following has been addressed in the PR:
Removing capitalisation from greeting label. When Verdaccio is welcoming a user based on their username, it is odd to capitalise the first letter, it is probably better to make zero assumptions about the formatting of the name rather than try and format it ourselves on the UI and simply accept whatever the auth source provides as a source of truth.
In the attached screenshot, you can see the strangeness I mention, "Imjacobclark" opposed to "imjacobclark".