This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: fixed failed to load all packages after login#73
Merged
juanpicado merged 1 commit intoverdaccio:4.x-masterfrom Jun 10, 2019
Merged
fix: fixed failed to load all packages after login#73juanpicado merged 1 commit intoverdaccio:4.x-masterfrom
juanpicado merged 1 commit intoverdaccio:4.x-masterfrom
Conversation
A login forces react to reload the list of available packages (by changing the state).
However the state (which triggers react to refresh) is set before storing the login token resulting in fetching (XHR GET) only the public packages as the token is not yet available in the GET request.
Fixed by setting the storage items ('username' and 'token') before this.setLoggedUser().
DanielRuf
approved these changes
Jun 9, 2019
juanpicado
approved these changes
Jun 9, 2019
Member
|
Thanks @coolsp , I really liked the detailed description in the commit, awesome 👍 |
Member
Author
|
Thanks @DanielRuf @juanpicado for this quick turnaround, great work 🥇 ! |
Member
|
shipped |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix:
Non-public packages not included in the package-list after login.
Description:
A login forces react to reload the list of available packages (by changing the state).
However the state (which triggers react to refresh) is set before storing the login token resulting in fetching (XHR GET) only the public packages as the token is not yet available in the GET request.
Fixed by setting the storage items ('username' and 'token') before this.setLoggedUser().
Resolves #72