station specific style kwargs for timeseries plots#482
Merged
vergauwenthomas merged 9 commits intodevfrom Oct 10, 2024
Merged
Conversation
Closed
vergauwenthomas
added a commit
that referenced
this pull request
May 13, 2025
* include a 'metadata-only' way of the Dataset. (#472) * include a 'metadata-only' way of the Dataset. * fixed the metadata only implementation (ready for review) + ipython magic line for showing plots in notebooks added * ready for review * small patches for v0.3.0 (#471) * bugfix for blacklist columns in metadf + lat, lon checks on the metadf setter * minor bugfixes (printing empty lists as warnings that are no warnings) * pipeline run * pre release version bump and testing publish workflow * publish action fix (#476) * bugfix for blacklist columns in metadf + lat, lon checks on the metadf setter * minor bugfixes (printing empty lists as warnings that are no warnings) * pipeline run * pre release version bump and testing publish workflow * without titan deploy test * testing publish * realease tested, now trigger on creation of tags * add a _ getter for present stationnames (handy for the gui-spinners) * include argument to specify colors in timeseriesplot with colorby=names (#479) * include argument to specify colors in timeseriesplot with colorby=names * run tests * update docstring to include styling changes * station specific style kwargs for timeseries plots (#482) * include argument to specify colors in timeseriesplot with colorby=names * run tests * update docstring to include styling changes * functionallity for passing station specific style kwargs implemented in lineplots * passed checks + documentation is checked * bugfixes and docstrings updates * delete unused vars_display setting * docstring bug fix * limit cartopy version so py39 is still valid (#484) * savepoint * savepoint * savepoint * Savepoint --> tests are running * analysis and doc of backend modules * bugfix for subsetting rawdf to mapped columns (if more defined in template than rawdata) * overwrite fill bugfix * bugfixes and GF tests * pytesting trigger on github workflow * update versions of used artifact actions * comment titan references in packaging and testing * pytest framework seperate workflow * new trigger on push * adding folium as dep. * without geemap but with ipython test * update geemap to latest * add setuptools to deps * setup autodoc structure for Dataset and Station * skip gee test on runner * made the gf test by default independent of GEE interaction * debugging statements for fixing github runner issue founding the solution of pytests * Bulk work on docstrings and documentation * Progress in docstrings * progress in documentation * progress in docstrings * Feat/chaining filling methods (#492) * Temporary removal of obstype compatibility test * Added filled gaps df such that fill methods can be chained * More optimal solution * Version change * Further deletion of filled gaps df * Chaining is a special case, so the comment might be confusing for all the non-chainers * removing the partially gapfill status --> a gap is filled (fully) or not filled at all. * uncomment the compatible obstype check with modeldata. * Update the test GF solution + minor bug fix --------- Co-authored-by: Thomas Vergauwen <thomas.vergauwen@meteo.be> * Workflows for v0.4 (#493) * Test on new workflow script * version bump + fixes in workflow * bump upload-artifact version * testing with workflows * add -f to rm in workflow * debug statements * attept bugfix for specifying libfolder on worker * improve version of download-artifact * specify path to build package * update libfolder in all tests + use matrix appoach over testfiles * debug statement and continue on error is True * minor bug fixes trown by tests * debug statements in workflow file * further debugging and version check added (first attempt) * fix gf tests * fix attempt in doc build + test install and version bump to 0.4.0a * fixes in the wrkflow script * debugging in workflow ... * further bugfixes in workflow * further progress in workflow * new attempt ... * further progress in workflow * doc build commands explicit in workflow * debugging pythonpath in doc builder on actions * debugging the doc build on actions * into one workflow file + pandoc install * drop unused workflows + debug in doc builder * debugging * debug attempt ... * testing gee in action * move workflow * Update test_workflow.yml * debuggin gee use on action * bugfix for gee use in action * main workflow with Gee service account authentication * make secrets reachable in tests * fix plot test * continue on error in pytest action * attempt to fix the pytests on runner * make tmp map in worker for mpl test generated summary and make an artifact of it * add logging in gf test and replace | by union in typhinting (for 3.9 compatibility). * minor bugfix in modeldatadf method + implemented an assert_non_exact framework in testing * make tmp argument dependant on the name of the testfile * attempt to make tmp dep of test * add a printing statement in the testscript * only mpl for plotting test * give GEE secrets as a variable * set dtype for gap records * add dtype for gap records + specify figsize in mpl test * Test conitunue on error for mpl output files * seperate non-failable step for --mpl * bugfix in mpl artifact * set english datetimes in xlabels * replace all | occurence to Union (py3.9 compatible work) * import bug fix * without the typealias form typing (not compatible with py3.9) * action run examples + start of introduction example + raise error when json file is not a json * better triggers * test triggering of workflow file * trigger workflow * bugfix trigger * propagate trigger events * trigger for workflow * bug typo * copilot suggestion for trigger fix * new attempt * next attempt ... * triggering an debugging * Update main_workflow.yml * Update main_workflow.yml * install jupyter before running examples * debug messages in workflo trigger * remove push trigger + debug steps in workflow trigger detect * test with gh-get-current-pr * check for label * new attempt * test the flow conditions * attempt 2 * next attempt * debugging * debugging * pass env to step * copilot help * next suggestion by copilot ... * pfff .... * check if github example works * example to if triggre * trigger * test with variable output * trigger * adjusted to application test * big attempt * cleanup * setup for testing the examples pipeline in the doc build * precommit hook to remove output from notebooks * replace the match with if loops (py3.9 compat) * replace match by if loops * fix the doc build * fix tests + cleanup of old testscripts * fix logging issues + doc improvements * update the introduction notebook * adding a present_observations argument to dataset and station * try fix the example run and example build step * execute examples in conf file * add qc example + try fix for example artifact names * adding obstype example * flexible build of docs failing in examples * bugfix in gee static plot + use LCZ (capital) everywhere * fix gee example * datasetmanagers API page + test avoid running connect_to_gee on action * avoid running connect_to_gee in action * passing the gee secret to run notebook job * attempt with runnen catcher in connect_to_gee * provide secrets to build doc job * fix issue in workflow file * fix default zorder + gf example in doc + gf example build in pipeline * fix for empty dataset df call * add example + test + docs + fixes for the analysis class * add analysis example in workflow for tests * compatible typehinting for py3.9 * rtd config fix * new test for rtd build * add a poetry show for rtd build * add export in pyproject * add poetry plugins in seperate group * add a build in rtd config * rtd build env from requirements file * bugfix in rtd build * debug statement in rtd build * the --all-extras keyword does not work in the poetry export pluging (think this is a bug) so use explicit group names * install the package itself in the rtd build script * test adding the package itsel in rtd build * rtd test * skip the output removal of notebooks in precommit, this makes rtd builds too dificult... * test with nb output * rtd attempt for prerunned nb's * rtd fix attempt * do not execute nb on rtd build * import handling of metob_toolkit in conf.py * run obstype example * comment out the nboutput remove in main workflow * test if output is pushed to github * reinitialize the precommithooks * test notebook push * next attempt ... * test rtd to run notebooks * rtd with poetry * debugging rt conf * new attempt * test variables in rtd builds * test with gee secret on RTD * bugfix * authentication func for RTD * debugging rtd auth * attempt for rtd GEE auth * new attempt rtd auth to gee * debugging RTD auth setup * RTD fix for auth * local run of ipynb * rename modules and fix tests * Remove GEE_Authenticator references and update publish.yml options * Refactor GEE API functions: improve docstrings, add type hints, and enhance error handling * Remove unused code and commented sections from various modules * Enhance documentation and logging in Analysis class: - Add Numpy-style docstrings for methods and class attributes - Implement type hints for method parameters and return types - Insert debug-level logging statements for method entry points - Correct variable names and typos in docstrings and comments * Refactor code structure for improved readability and maintainability * Enhance type hints and error handling in buddy_check module; improve docstrings for clarity and consistency * Refactor logging setup and enhance docstrings across multiple QC modules; improve type hints and error handling * Remove redundant type checks and logging statements in Dataset class for cleaner code * Refine logging instructions in copilot_prompts.txt for clarity and consistency; specify exclusion of entering-logs in property methods. * Remove redundant type checks in Analysis class methods for cleaner code * Refactor Gap class: enhance type hints, improve docstrings, and streamline logging for better clarity and consistency * Refactor code structure for improved readability and maintainability * Enhance docstrings and type hints across multiple modules for improved clarity and consistency; refine logging instructions and fix minor typos. * Enhance docstrings and type hints in SensorData class for improved clarity and consistency; streamline logging and remove redundant comments. * Enhance documentation and logging in Site and Station classes - Added detailed docstrings for parameters and return types in the Site class. - Improved logging messages for better traceability during initialization and method calls in both Site and Station classes. - Updated type hints for method parameters and return types for clarity. - Refined comments and docstrings to enhance readability and understanding of the code functionality. - Ensured consistency in the documentation style across methods in both classes. * Refactor template_build_prompt.py and timestampmatcher.py for improved clarity and functionality - Added logging to key functions in template_build_prompt.py for better traceability. - Enhanced function signatures with type hints and detailed docstrings for clarity. - Replaced deprecated function calls and fixed minor typos in both files. - Improved error handling and input validation in user interaction functions. - Updated the method for writing the template to use the new write_dict_to_json function. - Refactored the TimestampMatcher class to improve code readability and maintainability. - Added type hints and docstrings to methods in the TimestampMatcher class for better documentation. * Remove debug logging statements from multiple classes for cleaner initialization * Refactor error handling classes for improved clarity and consistency; remove redundant definitions and enhance documentation. * Enhance documentation in logging utilities; improve docstrings and remove redundant examples for clarity. * cleanup of code * Refactor documentation and code for MetObs Toolkit - Updated introduction notebook to reset execution counts for reproducibility. - Enhanced index.rst with installation instructions and usage examples. - Revised intro.rst to provide a clearer overview of toolkit objects and their functionalities. - Improved referencing section in paper/index.rst for clarity and citation format. - Corrected function name in functions.rst from import_data_from_pkl to import_dataset_from_pkl. - Clarified descriptions and fixed typos in geedatasetmanagers.rst. - Expanded reference documentation with new sections for ModelTimeSeries and Obstype. - Added SensorData reference documentation. - Removed redundant sync_records method from Station API documentation. - Cleaned up comments and whitespace in dataset.py and station.py for better readability. * cleanup * Enhance documentation and contributing guidelines - Updated the Pull Request guidelines in CONTRIBUTING.md to clarify the use of the ![RUN TESTS] badge. - Added a new contributing_link.md file to include the main CONTRIBUTING.md in the documentation. - Updated index.rst to include a link to the new contributing documentation. - Removed unnecessary whitespace in intro.rst. - Created a new document combine_seperate_datafiles.rst to guide users on combining multiple CSV files into a single dataset. - Deleted the outdated contributing_link.md from topics. - Revised GUI documentation to reflect the installation of Metobs-GUI only. - Updated topics index.rst to include new and relevant topics. - Removed the obsolete irregular_timestamp_handling.ipynb notebook. - Made improvements to metadata_only.ipynb for clarity and functionality. - Updated template_doc.ipynb to reflect changes in template usage and structure. * Refactor README for clarity and structure; enhance installation and usage sections * Enhance documentation for plotting functions; add detailed docstrings and logging * Remove obsolete plotting scripts: correlation_heatmap.py, correlation_scatter.py, and mpl_spatial.py * Refactor logging levels to debug in plotting functions; update type hints and fix variable name in qc_info_pies.py * Update docstring in label_defenitions.py to clarify purpose and remove unused code * Enhance Dataset.get_info method to include detailed output for observational, outlier, gap, metadata, and model data information; integrate printing functions for improved formatting. * Refactor get_info methods across multiple classes to utilize printing functions for improved formatting and consistency; enhance metadata output in SensorData, Station, and Template classes. * Add printing utility functions for formatted output in printing_collection.py * Refactor output formatting in Dataset and SensorData classes; utilize printing functions for label counts and enhance info retrieval in tests for model timeseries and gapfilled data. * bugfix * Refactor Dataset and Station classes to replace obsdata with sensordata; introduce get_sensor method for improved data access and consistency across the toolkit. * Add get_sensor method to Station documentation for improved clarity on available functionalities * Refactor add_modeldata_to_combdf function to improve interpolation of model data; ensure compatibility with varying time resolutions and remove duplicate rows. * Enhance aggregation methods in Analysis class; silence FutureWarnings for DataFrameGroupBy.mean and switch to 'mean' for consistency in data processing. * Fix centroid calculation in GEEStaticDatasetManager and GEEDynamicDatasetManager; ensure proper CRS transformation for accurate map centering. * Remove deprecated dev_environment.yml file to streamline project setup. * Implement code changes to enhance functionality and improve performance * precommit on all files * Refactor pyproject.toml: reorganize project metadata and dependencies for clarity * Refactor buddy_check.py and test_qc.py: improve code readability by formatting function parameters and comments * Refactor function signatures and comments in buddy_check.py and __init__.py for improved readability * Refactor imports and improve code formatting in analysis.py, dataset.py, and label_defenitions.py for enhanced readability * update the paper figure creation script to v0.4 compatible --------- Co-authored-by: NoahVerhoeven <noah.verhoeven@ugent.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.